From: Guenter Roeck <linux@roeck-us.net>
To: 06eba290-1794-854a-f999-86668211dcaf@roeck-us.net
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: Fix OMAP watchdog early handling
Date: Thu, 14 Oct 2021 13:18:27 -0700 [thread overview]
Message-ID: <20211014201827.GA4061613@roeck-us.net> (raw)
In-Reply-To: <88a8fe5229cd68fa0f1fd22f5d66666c1b7057a0.camel@duagon.com>
On Thu, Oct 14, 2021 at 12:22:29PM +0200, Walter Stoll wrote:
>
> TI's implementation does not service the watchdog even if the kernel
> command line parameter omap_wdt.early_enable is set to 1. This patch
> fixes the issue.
>
> Signed-off-by: Walter Stoll <walter.stoll@duagon.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/omap_wdt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
> index 1616f93dfad7..74d785b2b478 100644
> --- a/drivers/watchdog/omap_wdt.c
> +++ b/drivers/watchdog/omap_wdt.c
> @@ -268,8 +268,12 @@ static int omap_wdt_probe(struct platform_device *pdev)
> wdev->wdog.bootstatus = WDIOF_CARDRESET;
> }
>
> - if (!early_enable)
> + if (early_enable) {
> + omap_wdt_start(&wdev->wdog);
> + set_bit(WDOG_HW_RUNNING, &wdev->wdog.status);
> + } else {
> omap_wdt_disable(wdev);
> + }
>
> ret = watchdog_register_device(&wdev->wdog);
> if (ret) {
> --
> 2.33.0
>
>
prev parent reply other threads:[~2021-10-14 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 10:22 [PATCH] watchdog: Fix OMAP watchdog early handling Walter Stoll
2021-10-14 20:18 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014201827.GA4061613@roeck-us.net \
--to=linux@roeck-us.net \
--cc=06eba290-1794-854a-f999-86668211dcaf@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).