From: Rob Herring <robh@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kabel@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding
Date: Tue, 12 Jul 2022 12:28:32 -0600 [thread overview]
Message-ID: <20220712182832.GJ1823936-robh@kernel.org> (raw)
In-Reply-To: <20220707122730.45jtopop5cj7beni@pali>
On Thu, Jul 07, 2022 at 02:27:30PM +0200, Pali Rohár wrote:
> On Wednesday 06 July 2022 09:07:26 Rob Herring wrote:
> > On Tue, Jul 05, 2022 at 02:10:22AM +0200, Pali Rohár wrote:
> > > GPIO is optional and used for WDI logic.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > > Changes in v3:
> > > * Extend description
> > > ---
> > > Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > > index ab9641e845db..a0cf9e6c371d 100644
> > > --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > > +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> > > @@ -27,6 +27,10 @@ properties:
> > > description: This is a 1-byte memory-mapped address
> > > maxItems: 1
> > >
> > > + gpios:
> >
> > As I said before, add a name prefix: wdi-gpios
>
> So gpio with output direction should be really named that is input?
Names are based on the pins they connect to, so yes. The flags cell will
make it clear it is a GPIO output.
> I really do not understand this kind of thinking and making every device
> tree description totally illogical and inconsistent with all other.
I don't understand what you mean.
When there is a 2nd GPIO used for this binding, what do we call it?
'gpios' doesn't scale.
> > > + description: Optional GPIO used for controlling WDI (watchdog input) when WDI bit is not mapped to memory
Look at it this way, why do I have to find and read the description here
to know what 'gpios' is for when instead, it can be self-describing when
I look at the datasheet and the DT to see this is the GPIO connection
to WDI signal.
Rob
prev parent reply other threads:[~2022-07-12 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 0:10 [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding Pali Rohár
2022-07-05 0:10 ` [PATCH v3 2/2] watchdog: max63xx_wdt: Add support for specifying WDI logic via GPIO Pali Rohár
2022-07-06 15:07 ` [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding Rob Herring
2022-07-07 12:27 ` Pali Rohár
2022-07-12 18:28 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712182832.GJ1823936-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pali@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).