From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: [PATCH v2 0/2] watchdog: s3c2410_wdt: Simplify using dev_err_probe()
Date: Tue, 7 Mar 2023 07:56:01 +0100 [thread overview]
Message-ID: <20230307065603.2253054-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
changes since (implicit) v1, sent with Message-Id:
20230306090919.2206871-1-u.kleine-koenig@pengutronix.de:
- Rework patch #1 to keep s3c2410_get_wdt_drv_data() as a separate
function. The return value has to change however to make effective
use of dev_err_probe(). (I thought about using
return ERR_PTR(dev_err_probe(...));
but this looks too ugly and that's less effective because then
dev_err_probe cannot be compiled into a tail call.)
- Squash patches #2 and #3. This destroys the pretty bloatometer
statistic, in fact bloatometer diagnoses that the code gets bigger.
I'm a bit surprised but didn't try to understand it. I assume that's
because the additional parameter that dev_err_probe has to get over
dev_err is the culprit. Still given that the error code is now
included in the error message this is an IMHO nice patch.
Now that Gunter likes patch #1 better than the one from v1, I wonder
about his position about patch #2.
Best regards
Uwe
Uwe Kleine-König (2):
watchdog: s3c2410: Make s3c2410_get_wdt_drv_data() return an int
watchdog: s3c2410_wdt: Simplify using dev_err_probe()
drivers/watchdog/s3c2410_wdt.c | 47 +++++++++++++++-------------------
1 file changed, 20 insertions(+), 27 deletions(-)
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
prerequisite-patch-id: 775bdd863307268e1ef16250bf2f40862637b453
prerequisite-patch-id: 924ddfbe583e97e7c9a46c2460ecbc88c29ee319
--
2.39.1
next reply other threads:[~2023-03-07 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 6:56 Uwe Kleine-König [this message]
2023-03-07 6:56 ` [PATCH v2 1/2] watchdog: s3c2410: Make s3c2410_get_wdt_drv_data() return an int Uwe Kleine-König
2023-03-07 16:37 ` Guenter Roeck
2023-03-07 6:56 ` [PATCH v2 2/2] watchdog: s3c2410_wdt: Simplify using dev_err_probe() Uwe Kleine-König
2023-03-07 16:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307065603.2253054-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alim.akhtar@samsung.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).