Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
	Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: Yong Liang <yong.liang@mediatek.com>,
	wim@linux-watchdog.org, linux@roeck-us.net,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-watchdog@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Devicetree List <devicetree@vger.kernel.org>,
	chang-an.chen@mediatek.com, freddy.hsin@mediatek.com,
	Stephen Boyd <sboyd@kernel.org>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>
Subject: Re: [PATCH v10 2/2] watchdog: mtk_wdt: mt8183: Add reset controller
Date: Wed, 8 Jan 2020 15:13:37 +0100
Message-ID: <2e0a2ce4-0107-f49f-57fd-11b3b87dce45@gmail.com> (raw)
In-Reply-To: <CANMq1KD3n5r1ACy2acKgXTfTLHMsONzT-NscL=AoY1Jr-eqdww@mail.gmail.com>



On 08/01/2020 10:25, Nicolas Boichat wrote:
> On Mon, Jan 6, 2020 at 11:11 AM Jiaxin Yu <jiaxin.yu@mediatek.com> wrote:
>>
>> Add reset controller API in watchdog driver.
>> Besides watchdog, MTK toprgu module alsa provide sub-system (eg, audio,
>> camera, codec and connectivity) software reset functionality.
> 
> You add support for reset controller on both 8183 and 2712, do you
> want to say that in the commit title and message?
> 

I normally prefer to split that into at least two patches.

Regards,
Matthias

>>
>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
>> Reviewed-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
>> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>>  drivers/watchdog/mtk_wdt.c | 105 ++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 104 insertions(+), 1 deletion(-)

      reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06  3:11 [PATCH v10 0/2] ASoC: mt8183: fix audio playback slowly after playback Jiaxin Yu
2020-01-06  3:11 ` [PATCH v10 1/2] dt-bindings: mediatek: mt8183: Add #reset-cells Jiaxin Yu
2020-01-06 21:57   ` Rob Herring
2020-01-07 18:29     ` Guenter Roeck
2020-01-09  1:58     ` Yong Liang
2020-01-08  9:23   ` Nicolas Boichat
2020-01-09  3:10     ` Yong Liang
2020-01-06  3:11 ` [PATCH v10 2/2] watchdog: mtk_wdt: mt8183: Add reset controller Jiaxin Yu
2020-01-08  9:25   ` Nicolas Boichat
2020-01-08 14:13     ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e0a2ce4-0107-f49f-57fd-11b3b87dce45@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=chang-an.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=freddy.hsin@mediatek.com \
    --cc=jiaxin.yu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=p.zabel@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=yingjoe.chen@mediatek.com \
    --cc=yong.liang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git