From: Florian Fainelli <f.fainelli@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>, linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org, Paul Burton <paulburton@kernel.org>,
Denis Efremov <efremov@linux.com>
Subject: Re: [PATCH 1/2] watchdog: mtx-1: Drop au1000.h header inclusion
Date: Wed, 11 Dec 2019 19:38:29 -0800 [thread overview]
Message-ID: <3fdc99fa-f75c-33d4-e1c4-ec8ad185e2cd@gmail.com> (raw)
In-Reply-To: <21b7be75-db61-3b14-c57c-04af0b78b347@roeck-us.net>
On 12/11/2019 5:35 PM, Guenter Roeck wrote:
> On 12/11/19 1:02 PM, Florian Fainelli wrote:
>> Including au1000.h from the machine specific header directory prevents
>> this driver from being built on any other platforms (MIPS included).
>> Since we do not use any definitions, drop it.
>>
>> Reported-by: Denis Efremov <efremov@linux.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> drivers/watchdog/mtx-1_wdt.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
>> index 25a92857b217..aeca22f7450e 100644
>> --- a/drivers/watchdog/mtx-1_wdt.c
>> +++ b/drivers/watchdog/mtx-1_wdt.c
>> @@ -41,8 +41,6 @@
>> #include <linux/uaccess.h>
>> #include <linux/gpio/consumer.h>
>> -#include <asm/mach-au1x00/au1000.h>
>> -
>> #define MTX1_WDT_INTERVAL (5 * HZ)
>> static int ticks = 100 * HZ;
>>
>
> Given that this is nothing but yet another gpio watchdog driver, I'd
> personally rather have it merged with gpio_wdt.c. On a higher level,
> cleaning up old-style watchdog drivers, without converting them to
> using the watchdog core, is a waste of time.
If that makes you feel any better, I was not planning on going further
than that, and yes, removing this driver and using gpio_wdt.c would be
the way to go, this driver greatly predates gpio_wdt.c and I have since
then not had access to my MTX-1 platforms which is why this did not
happen. We can attempt a "blind conversion" without testing, but what
good would that make, not sure.
>
> Wim, should we make it a policy to reject patches into old-style drivers
> unless they fix a real bug ? It is getting a pain to have to review those
> patches.
>
> Thanks,
> Guenter
--
Florian
next prev parent reply other threads:[~2019-12-12 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:02 [PATCH 0/2] watchdog: mtx-1: Relax build dependencies Florian Fainelli
2019-12-11 21:02 ` [PATCH 1/2] watchdog: mtx-1: Drop au1000.h header inclusion Florian Fainelli
2019-12-12 1:35 ` Guenter Roeck
2019-12-12 3:38 ` Florian Fainelli [this message]
2019-12-12 18:19 ` Guenter Roeck
2019-12-12 18:28 ` Florian Fainelli
2019-12-11 21:02 ` [PATCH 2/2] watchdog: Relax dependencies for CONFIG_WDT_MTX1 Florian Fainelli
2019-12-11 23:46 ` [PATCH 0/2] watchdog: mtx-1: Relax build dependencies Denis Efremov
2019-12-12 1:39 ` Guenter Roeck
2019-12-12 3:41 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fdc99fa-f75c-33d4-e1c4-ec8ad185e2cd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paulburton@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).