From: Guenter Roeck <linux@roeck-us.net>
To: 王擎 <wangqing@vivo.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available
Date: Fri, 9 Apr 2021 21:35:38 -0700 [thread overview]
Message-ID: <45e40a84-9d98-87e7-659e-6c34834e6280@roeck-us.net> (raw)
In-Reply-To: <AKoADwCwDn4bllbdA00CnKoA.3.1618024305455.Hmail.wangqing@vivo.com>
On 4/9/21 8:11 PM, 王擎 wrote:
>
>> On 4/9/21 7:42 PM, 王擎 wrote:
>>>
>>>> On 4/9/21 2:55 AM, Wang Qing wrote:
>>>>> Use the bark interrupt as the pretimeout notifier if available.
>>>>>
>>>>> By default, the pretimeout notification shall occur one second earlier
>>>>> than the timeout.
>>>>>
>>>>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>>>>> ---
>>>>> drivers/watchdog/mtk_wdt.c | 47 +++++++++++++++++++++++++++++++++++++++++++---
>>>>> 1 file changed, 44 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
>>>>> index 97ca993..8b919cc
>>>>> --- a/drivers/watchdog/mtk_wdt.c
>>>>> +++ b/drivers/watchdog/mtk_wdt.c
>>>>> @@ -25,6 +25,7 @@
>>>>> #include <linux/reset-controller.h>
>>>>> #include <linux/types.h>
>>>>> #include <linux/watchdog.h>
>>>>> +#include <linux/interrupt.h>
>>>>>
>>>>> #define WDT_MAX_TIMEOUT 31
>>>>> #define WDT_MIN_TIMEOUT 1
>>>>> @@ -234,18 +235,35 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev)
>>>>> void __iomem *wdt_base = mtk_wdt->wdt_base;
>>>>> int ret;
>>>>>
>>>>> - ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);
>>>>> + ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout - wdt_dev->pretimeout);
>>>>
>>>> That looks suspiciously like the real watchdog won't happen at all.
>>>> What will happen if the pretimeout governor is set to none ?
>>>>
>>>> Guenter
>>>>
>>> The pretimeout governor is panic by default. If pretimeout is enabled and the governor is
>>> set to none, it means the timeout behavior does not need to be processed, only printing.
>>>
>>
>> That was not my question. My question was if the real timeout happens in that case.
>>
>> Guenter
>>
> Yes, the real timeout will happen. After WDT timeout, IRQ is sent out instead of
> reset signal first. In order to ensure that CPU does not get stuck after IRQ is sent out,
> WDT will time again and send reset signal to reset.
>
When will that be, or in other words how does the chip know when to time out ?
After all, only a single timeout value is written into the chip. I don't see how
it would know to reset the chip after wdt_dev->timeout.
Guenter
next prev parent reply other threads:[~2021-04-10 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 9:55 [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available Wang Qing
2021-04-09 12:56 ` Guenter Roeck
2021-04-10 2:42 ` 王擎
2021-04-10 2:56 ` Guenter Roeck
2021-04-10 3:11 ` 王擎
2021-04-10 4:35 ` Guenter Roeck [this message]
2021-04-10 12:19 ` 王擎
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e40a84-9d98-87e7-659e-6c34834e6280@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wangqing@vivo.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).