From: Guenter Roeck <linux@roeck-us.net>
To: Jamie Iles <quic_jiles@quicinc.com>, linux-watchdog@vger.kernel.org
Cc: wim@linux-watchdog.org, zhangshaokun@hisilicon.com
Subject: Re: [PATCH] watchdog: sbsa: only use 32-bit accessors
Date: Fri, 3 Sep 2021 07:05:50 -0700 [thread overview]
Message-ID: <4dd48839-5695-dfbe-2270-423fb5431ba6@roeck-us.net> (raw)
In-Reply-To: <20210903112101.493552-1-quic_jiles@quicinc.com>
On 9/3/21 4:21 AM, Jamie Iles wrote:
> SBSA says of the generic watchdog:
>
> All registers are 32 bits in size and should be accessed using 32-bit
> reads and writes. If an access size other than 32 bits is used then
> the results are IMPLEMENTATION DEFINED.
>
> and for qemu, the implementation will only allow 32-bit accesses
> resulting in a synchronous external abort when configuring the watchdog.
> Use lo_hi_* accessors rather than a readq/writeq.
>
> Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sbsa_gwdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index ee9ff38929eb..6f4319bdbc50 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -130,7 +130,7 @@ static u64 sbsa_gwdt_reg_read(struct sbsa_gwdt *gwdt)
> if (gwdt->version == 0)
> return readl(gwdt->control_base + SBSA_GWDT_WOR);
> else
> - return readq(gwdt->control_base + SBSA_GWDT_WOR);
> + return lo_hi_readq(gwdt->control_base + SBSA_GWDT_WOR);
> }
>
> static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> @@ -138,7 +138,7 @@ static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> if (gwdt->version == 0)
> writel((u32)val, gwdt->control_base + SBSA_GWDT_WOR);
> else
> - writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
> + lo_hi_writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
> }
>
> /*
>
next prev parent reply other threads:[~2021-09-03 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 11:21 [PATCH] watchdog: sbsa: only use 32-bit accessors Jamie Iles
2021-09-03 14:05 ` Guenter Roeck [this message]
2021-09-06 11:30 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd48839-5695-dfbe-2270-423fb5431ba6@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=quic_jiles@quicinc.com \
--cc=wim@linux-watchdog.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).