From: Guenter Roeck <linux@roeck-us.net>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org
Subject: Re: [PATCH 2/2] watchdog: pm8916_wdt: fix missing include
Date: Sun, 8 Sep 2019 15:54:07 -0700 [thread overview]
Message-ID: <50a36f88-ab09-44a1-db69-b4fa66e73534@roeck-us.net> (raw)
In-Reply-To: <20190906203054.26725-2-jorge.ramirez-ortiz@linaro.org>
On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote:
> As per Documentation/process/submit-checklist.rst, when using a
> facility #include the file that defines/declares that facility.
>
> Don't depend on other header files pulling in ones that you use.
>
Correct, but then also don't include header files you don't use.
In this case, the include of linux/bitops.h is no longer necessary
if linux/bits.h is included since the driver doesn't really use bit
operations, only bit masks.
Guenter
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/watchdog/pm8916_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/pm8916_wdt.c b/drivers/watchdog/pm8916_wdt.c
> index cb5304c26ac3..b8d9df0f96f7 100644
> --- a/drivers/watchdog/pm8916_wdt.c
> +++ b/drivers/watchdog/pm8916_wdt.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <linux/bitops.h>
> +#include <linux/bits.h>
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
>
next prev parent reply other threads:[~2019-09-08 22:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 20:30 [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow Jorge Ramirez-Ortiz
2019-09-06 20:30 ` [PATCH 2/2] watchdog: pm8916_wdt: fix missing include Jorge Ramirez-Ortiz
2019-09-08 22:54 ` Guenter Roeck [this message]
2019-09-08 22:50 ` [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow Guenter Roeck
[not found] ` <CAMZdPi-P_AopbbyJEWDbnm7X8MtxTzs=MN13+UFndL2OK5VReg@mail.gmail.com>
2019-09-11 17:54 ` Guenter Roeck
2019-09-13 10:36 ` Loic Poulain
2019-09-13 12:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50a36f88-ab09-44a1-db69-b4fa66e73534@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bjorn.andersson@linaro.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).