From: Guenter Roeck <linux@roeck-us.net>
To: Matteo Croce <mcroce@redhat.com>
Cc: linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH] watchdog: i6300esb: stop printing kernel addresses
Date: Mon, 18 Mar 2019 17:17:11 -0700 [thread overview]
Message-ID: <5ace654b-aa61-5799-095a-84fb7adcfce4@roeck-us.net> (raw)
In-Reply-To: <CAGnkfhzN_iutkyo5QAC8xTavpA=W=vG6VZW+b5nD1m+3PtiLbQ@mail.gmail.com>
On 3/18/19 4:53 PM, Matteo Croce wrote:
> On Mon, Mar 18, 2019 at 3:53 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 3/17/19 6:19 PM, Matteo Croce wrote:
>>> Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
>>> i6300esb prints "____ptrval____" instead of actual addresses:
>>>
>>> i6300ESB timer 0000:00:03.0: initialized (0x(____ptrval____)). heartbeat=30 sec (nowayout=1)
>>>
>>> Instead of changing the print to "%px", and leaking kernel addresses,
>>> just remove the print completely, cfr. e.g. commit 071929dbdd865f77
>>> ("arm64: Stop printing the virtual memory layout").
>>>
>>> Signed-off-by: Matteo Croce <mcroce@redhat.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>>> ---
>>> drivers/watchdog/i6300esb.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/watchdog/i6300esb.c b/drivers/watchdog/i6300esb.c
>>> index 950c71a8bb22..e312a2aeecad 100644
>>> --- a/drivers/watchdog/i6300esb.c
>>> +++ b/drivers/watchdog/i6300esb.c
>>> @@ -328,8 +328,8 @@ static int esb_probe(struct pci_dev *pdev,
>>> goto err_unmap;
>>> }
>>> dev_info(&pdev->dev,
>>> - "initialized (0x%p). heartbeat=%d sec (nowayout=%d)\n",
>>> - edev->base, edev->wdd.timeout, nowayout);
>>> + "initialized. heartbeat=%d sec (nowayout=%d)\n",
>>> + edev->wdd.timeout, nowayout);
>>> return 0;
>>>
>>> err_unmap:
>>>
>>
>
> Nit: can someone add the fixes tag before merge?
>
> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
>
This isn't really a bug fix.
Guenter
prev parent reply other threads:[~2019-03-19 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 1:19 [PATCH] watchdog: i6300esb: stop printing kernel addresses Matteo Croce
2019-03-18 2:53 ` Guenter Roeck
2019-03-18 23:53 ` Matteo Croce
2019-03-19 0:17 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ace654b-aa61-5799-095a-84fb7adcfce4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).