From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] riscv: dts: starfive: jh7100: Add watchdog node
Date: Thu, 9 Mar 2023 10:54:43 +0800 [thread overview]
Message-ID: <5f11e476-6017-46e3-f601-d192765c5fb2@starfivetech.com> (raw)
In-Reply-To: <CAJM55Z9-BK1zPop_C9JX8qGLpzGXPzizUSyEtaevwbQ4NT2xaQ@mail.gmail.com>
On 2023/3/9 0:09, Emil Renner Berthing wrote:
> On Wed, 8 Mar 2023 at 04:42, Xingyu Wu <xingyu.wu@starfivetech.com> wrote:
>>
>> Add watchdog node for the StarFive JH7100 RISC-V SoC.
>>
>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>> ---
>> arch/riscv/boot/dts/starfive/jh7100.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi
>> index 000447482aca..1eb7c21a94fd 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7100.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi
>> @@ -238,5 +238,15 @@ i2c3: i2c@12460000 {
>> #size-cells = <0>;
>> status = "disabled";
>> };
>> +
>> + wdog: watchdog@12480000 {
>
> I don't see anything referencing this node, so the label can be dropped.
> With that fixed:
> Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
>
Will drop the label and just use:
watchdog@12480000 {
Best regards,
Xingyu Wu
prev parent reply other threads:[~2023-03-09 2:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 3:40 [PATCH v4 0/3] Add watchdog driver for StarFive JH7100/JH7110 RISC-V SoCs Xingyu Wu
2023-03-08 3:40 ` [PATCH v4 1/3] dt-bindings: watchdog: Add watchdog for StarFive JH7100 and JH7110 Xingyu Wu
2023-03-09 7:30 ` Krzysztof Kozlowski
2023-03-09 8:13 ` Xingyu Wu
2023-03-09 8:35 ` Krzysztof Kozlowski
2023-03-09 8:44 ` Xingyu Wu
2023-03-09 8:56 ` Krzysztof Kozlowski
2023-03-09 8:59 ` Xingyu Wu
2023-03-08 3:40 ` [PATCH v4 2/3] drivers: watchdog: Add StarFive Watchdog driver Xingyu Wu
2023-03-08 15:07 ` Emil Renner Berthing
2023-03-08 15:17 ` Guenter Roeck
2023-03-09 3:38 ` Xingyu Wu
2023-03-09 7:08 ` Xingyu Wu
2023-03-09 8:55 ` Emil Renner Berthing
2023-03-09 9:31 ` Xingyu Wu
2023-03-09 13:46 ` Emil Renner Berthing
2023-03-10 2:25 ` Xingyu Wu
2023-03-08 3:40 ` [PATCH v4 3/3] riscv: dts: starfive: jh7100: Add watchdog node Xingyu Wu
2023-03-08 16:09 ` Emil Renner Berthing
2023-03-09 2:54 ` Xingyu Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f11e476-6017-46e3-f601-d192765c5fb2@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).