From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] watchdog: mtx-1: drop au1000.h header file
Date: Sun, 16 May 2021 16:33:43 -0700 [thread overview]
Message-ID: <6870b21e-c993-aec4-4214-ea25e6da1b0f@roeck-us.net> (raw)
In-Reply-To: <d22c3fb9-51c7-6f1f-f9ce-e761ad25502c@infradead.org>
On 5/16/21 4:29 PM, Randy Dunlap wrote:
> On 5/16/21 4:08 PM, Guenter Roeck wrote:
>> On 5/16/21 2:17 PM, Randy Dunlap wrote:
>>> The mtx-1_wdt driver does not need the au1000.h header file.
>>> Instead, the header file causes build errors, so drop it.
>>>
>>> This change fixes multiple build errors, all in au1000.h. E.g.:
>>>
>>> In file included from ../drivers/watchdog/mtx-1_wdt.c:44:
>>> ../arch/mips/include/asm/mach-au1x00/au1000.h: In function 'alchemy_rdsys':
>>> ../arch/mips/include/asm/mach-au1x00/au1000.h:603:36: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? [-Werror=implicit-function-declaration]
>>> 603 | void __iomem *b = (void __iomem *)KSEG1ADDR(AU1000_SYS_PHYS_ADDR);
>>> ../arch/mips/include/asm/mach-au1x00/au1000.h:603:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>> 603 | void __iomem *b = (void __iomem *)KSEG1ADDR(AU1000_SYS_PHYS_ADDR);
>>>
>>> Fixes: 04bf3b4f5fc0 ("[WATCHDOG] MTX-1 Watchdog driver")
>>
>> More like
>>
>> Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
>
> Duh. Thanks.
>
That patch wasn't exactly one of my better ideas.
$ git log v4.10.. | grep da2a68b3eb47
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Commit da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Me blush :-(
Guenter
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
>>> Cc: Guenter Roeck <linux@roeck-us.net>
>>> Cc: linux-watchdog@vger.kernel.org
>>> Cc: Florian Fainelli <f.fainelli@gmail.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>>> ---
>>> drivers/watchdog/mtx-1_wdt.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> --- linux-next-20210514.orig/drivers/watchdog/mtx-1_wdt.c
>>> +++ linux-next-20210514/drivers/watchdog/mtx-1_wdt.c
>>> @@ -41,8 +41,6 @@
>>> #include <linux/uaccess.h>
>>> #include <linux/gpio/consumer.h>
>>> -#include <asm/mach-au1x00/au1000.h>
>>> -
>>> #define MTX1_WDT_INTERVAL (5 * HZ)
>>> static int ticks = 100 * HZ;
next prev parent reply other threads:[~2021-05-16 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 21:17 [PATCH] watchdog: mtx-1: drop au1000.h header file Randy Dunlap
2021-05-16 23:08 ` Guenter Roeck
2021-05-16 23:29 ` Randy Dunlap
2021-05-16 23:33 ` Guenter Roeck [this message]
2021-05-16 23:54 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6870b21e-c993-aec4-4214-ea25e6da1b0f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).