From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"wim@iguana.be" <wim@iguana.be>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: mvebu: dts: connect interrupt for WD on armada-38x
Date: Thu, 12 Oct 2017 20:12:36 +0000 [thread overview]
Message-ID: <69ab72d5008744df9455712c2c821730@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: 874lr4bgdh.fsf@free-electrons.com
On 13/10/17 03:17, Gregory CLEMENT wrote:
> Hi Chris,
>
> On mer., oct. 11 2017, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>
>> The watchdog timer interrupt is available internally on the Armada-38x
>> SoCs. Connect it so that we can have the orion_wdt_irq generate debug
>> information when a watchdog timeout occurs.
>
> Given the patch 2, when an interrupt is provided by the dt, then the
> behavior of the watchdog changes. So we can't do it for all the
> platform.
>
> As you propose on your cover letter it is better to set it at board
> level.
>
> So instead of this patch you should update the binding documentation
> with this new resources. Thanks to this each board developer will be
> able to decide to use this feature or not.
Agreed. I'll drop this patch in favor of a documentation update in v2.
>
> Thanks,
>
> Gregory
>
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>> arch/arm/boot/dts/armada-38x.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
>> index 7ff0811e61db..9ac76c54c9e5 100644
>> --- a/arch/arm/boot/dts/armada-38x.dtsi
>> +++ b/arch/arm/boot/dts/armada-38x.dtsi
>> @@ -408,6 +408,7 @@
>> reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>;
>> clocks = <&coreclk 2>, <&refclk>;
>> clock-names = "nbclk", "fixed";
>> + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
>> };
>>
>> cpurst: cpurst@20800 {
>> --
>> 2.14.2
>>
>
prev parent reply other threads:[~2017-10-12 20:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 2:29 [PATCH 0/3] getting more output from orion_wdt Chris Packham
2017-10-11 2:29 ` [PATCH 1/3] watchdog: orion: fix typo Chris Packham
2017-10-11 3:35 ` Guenter Roeck
2017-10-11 2:29 ` [PATCH 2/3] watchdog: orion: don't enable rstout if an interrupt is configured Chris Packham
2017-10-11 3:41 ` Guenter Roeck
2017-10-11 4:30 ` Chris Packham
2019-02-27 20:59 ` Chris Packham
2019-02-27 23:07 ` Guenter Roeck
2019-03-04 22:51 ` [PATCH 0/2] watchdog: orion_wdt: add pretimeout support Chris Packham
2019-03-04 22:51 ` [PATCH 1/2] watchdog: orion_wdt: remove orion_wdt_set_timeout Chris Packham
2019-03-05 17:17 ` Guenter Roeck
2019-03-04 22:51 ` [PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout Chris Packham
2019-03-05 0:57 ` Andrew Lunn
2019-03-05 1:26 ` Chris Packham
2019-03-05 2:09 ` Andrew Lunn
2019-03-05 17:27 ` Guenter Roeck
2017-10-11 2:29 ` [PATCH 3/3] ARM: mvebu: dts: connect interrupt for WD on armada-38x Chris Packham
2017-10-12 14:16 ` Gregory CLEMENT
2017-10-12 20:12 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69ab72d5008744df9455712c2c821730@svr-chch-ex1.atlnz.lc \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).