linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Tomer Maimon <tmaimon77@gmail.com>,
	wim@linux-watchdog.org, robh+dt@kernel.org, mark.rutland@arm.com,
	joel@jms.id.au, avifishman70@gmail.com, tali.perry1@gmail.com,
	yuenn@google.com, benjaminfair@google.com
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation
Date: Sun, 1 Mar 2020 02:05:58 -0800	[thread overview]
Message-ID: <6ecf9a6b-8fca-1e7a-10d0-ee518e6ecf64@roeck-us.net> (raw)
In-Reply-To: <20200301094040.123189-2-tmaimon77@gmail.com>

On 3/1/20 1:40 AM, Tomer Maimon wrote:
> Add device tree restart priority documentation.
> 

I think this warrants an explanation _why_ this is needed.
What is the use case ? Not just theory, please.

Guenter

> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
>  Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> index 6d593003c933..0a0f86a25eb0 100644
> --- a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> @@ -17,6 +17,7 @@ Required clocking property, have to be one of:
>  
>  Optional properties:
>  - timeout-sec : Contains the watchdog timeout in seconds
> +- nuvoton,restart-priority : Contains the card restart priority.
>  
>  Example:
>  
> @@ -25,4 +26,5 @@ timer@f000801c {
>      interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
>      reg = <0xf000801c 0x4>;
>      clocks = <&clk NPCM7XX_CLK_TIMER>;
> +	nuvoton,restart-priority = <155>;
>  };
> 


  reply	other threads:[~2020-03-01 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01  9:40 [PATCH v1 0/4] watchdog: npcm: support new capabilities Tomer Maimon
2020-03-01  9:40 ` [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation Tomer Maimon
2020-03-01 10:05   ` Guenter Roeck [this message]
     [not found]     ` <CAP6Zq1gYvoGwNwr2zCopQ5CcyVUjgdYK6yX1wVMmWh5gapp+zQ@mail.gmail.com>
2020-03-01 15:46       ` Guenter Roeck
2020-03-01  9:40 ` [PATCH v1 2/4] watchdog: npcm: add restart priority support Tomer Maimon
2020-03-01  9:40 ` [PATCH v1 3/4] dt-binding: watchdog: add bootstatus reset type documentation Tomer Maimon
2020-03-01  9:40 ` [PATCH v1 4/4] watchdog: npcm: sets card ext1 and ext2 bootstatus during probe Tomer Maimon
2020-03-01 10:48   ` Guenter Roeck
     [not found]     ` <CAP6Zq1hPsnJ1UxAQ-wK_pkaJqzWRQ-_g5-k0Kag2YoP+c2fPjQ@mail.gmail.com>
2020-03-01 16:10       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ecf9a6b-8fca-1e7a-10d0-ee518e6ecf64@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=wim@linux-watchdog.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).