linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Hauke Mehrtens <hauke@hauke-m.de>, wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org, john@phrozen.org, dev@kresin.me
Subject: Re: [PATCH v2 2/3] wdt: lantiq: Convert to watchdog_device
Date: Mon, 10 Sep 2018 06:26:58 -0700	[thread overview]
Message-ID: <6fe2a9bf-4b8d-5958-6737-18c78368f495@roeck-us.net> (raw)
In-Reply-To: <6315a579-3249-e83b-69ea-54ac13b15799@hauke-m.de>

On 09/09/2018 02:07 PM, Hauke Mehrtens wrote:
[ ... ]>
>>> +    if (!priv->clk_rate) {
>>> +        dev_err(dev, "clock has wrong value of 0");
>>
>> This is misleading: It is not known if the clock rate is indeed 0.
>> It is only known that the clock rate is below LTQ_WDT_DIVIDER.
> 
> Ok I will update this.
> 
>>> +        return -EIO;
>>
>> I am not happy with EIO in this case. There is no indication
>> of an I/O error.
> 
> Is -EINVAL better?
> 

Yes.

Thanks,
Guenter

  reply	other threads:[~2018-09-10 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-02 11:32 [PATCH v2 0/3] wdt: lantiq: Convert to watchdog_device Hauke Mehrtens
2018-09-02 11:32 ` [PATCH v2 1/3] wdt: lantiq: update register names to better match spec Hauke Mehrtens
2018-09-03 23:09   ` [v2,1/3] " Guenter Roeck
2018-09-09 21:04     ` Hauke Mehrtens
2018-09-02 11:32 ` [PATCH v2 2/3] wdt: lantiq: Convert to watchdog_device Hauke Mehrtens
2018-09-03 23:43   ` Guenter Roeck
2018-09-09 21:07     ` Hauke Mehrtens
2018-09-10 13:26       ` Guenter Roeck [this message]
2018-09-02 11:32 ` [PATCH v2 3/3] wdt: lantiq: add get_timeleft callback Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fe2a9bf-4b8d-5958-6737-18c78368f495@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=dev@kresin.me \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).