From: Oliver Neukum <oneukum@suse.com>
To: Alexey Klimov <klimov.linux@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
Guenter Roeck <linux@roeck-us.net>,
Oliver Neukum <oneukum@suse.com>,
USB list <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
atishp@rivosinc.com, atishp@atishpatra.org,
Yury Norov <yury.norov@gmail.com>,
Alexey Klimov <aklimov@redhat.com>,
Aaron Tomlin <atomlin@redhat.com>
Subject: Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog device
Date: Tue, 26 Jul 2022 09:48:21 +0200 [thread overview]
Message-ID: <7770401d-fe3d-bda4-a2e2-55cd004a2d07@suse.com> (raw)
In-Reply-To: <CALW4P+Kd_XdvzGfA=Cmtu0c=kEHfhp2pph2Wh0Sa8Fm8GxDRTA@mail.gmail.com>
On 26.07.22 02:21, Alexey Klimov wrote:
> On Mon, Jul 25, 2022 at 9:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>>
>> On Mon, Jul 25, 2022 at 04:06:05AM +0100, Alexey Klimov wrote:
>
> [..]
>
>> Anyway, driver looks good to me, nice work!
>>
>> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks, Greg. If you don't mind I'll use your tag in next version
> after making changes suggested by Guenter since there will be no
> significant functional changes. If code will change a lot, then the
> process (Documentation/process/submitting-patches.rst) will require me
> to drop the tag.
Hi,
while thinking about this a question arose. How does this
device react to a USB reset? A watchdog that can be disabled
by a simple reset does not like very reliable to me.
Do you need to implement pre/post_reset() ?
Regards
Oliver
next prev parent reply other threads:[~2022-07-26 7:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 3:06 [PATCH v5] watchdog: add driver for StreamLabs USB watchdog device Alexey Klimov
2022-07-25 8:51 ` Greg KH
2022-07-25 14:07 ` Guenter Roeck
2022-07-26 0:21 ` Alexey Klimov
2022-07-26 7:48 ` Oliver Neukum [this message]
2022-07-31 2:34 ` Alexey Klimov
2022-07-31 8:20 ` Guenter Roeck
2022-07-31 14:17 ` Alan Stern
2022-08-01 4:00 ` Alexey Klimov
2022-08-01 3:06 ` Alexey Klimov
2022-08-01 9:47 ` Oliver Neukum
2022-07-25 14:02 ` Guenter Roeck
2022-07-26 1:31 ` Alexey Klimov
2022-07-26 3:24 ` Guenter Roeck
2022-08-01 2:58 ` Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7770401d-fe3d-bda4-a2e2-55cd004a2d07@suse.com \
--to=oneukum@suse.com \
--cc=aklimov@redhat.com \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=atomlin@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).