From: Guenter Roeck <linux@roeck-us.net>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, wim@linux-watchdog.org
Cc: p.zabel@pengutronix.de, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: dw_wdt: Fix duplicate included linux/kernel.h
Date: Thu, 13 May 2021 06:56:59 -0700 [thread overview]
Message-ID: <8b670d5a-dc16-0709-c55a-42832ac17bfe@roeck-us.net> (raw)
In-Reply-To: <1620904182-74107-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On 5/13/21 4:09 AM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Changes in v2:
> -Adjust header file order, for the follow advice:
> https://lore.kernel.org/patchwork/patch/1428192/
>
> drivers/watchdog/dw_wdt.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..cd57884 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
> */
>
> #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
> #include <linux/clk.h>
> +#include <linux/debugfs.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> +#include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> +#include <linux/limits.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
> #include <linux/of.h>
> -#include <linux/pm.h>
> #include <linux/platform_device.h>
> +#include <linux/pm.h>
> #include <linux/reset.h>
> #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>
> #define WDOG_CONTROL_REG_OFFSET 0x00
> #define WDOG_CONTROL_REG_WDT_EN_MASK 0x01
>
prev parent reply other threads:[~2021-05-13 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 11:09 [PATCH v2] watchdog: dw_wdt: Fix duplicate included linux/kernel.h Jiapeng Chong
2021-05-13 13:56 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b670d5a-dc16-0709-c55a-42832ac17bfe@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).