From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Stefan Riedmueller <s.riedmueller@phytec.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Support Opensource <Support.Opensource@diasemi.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] watchdog: da9062: No need to ping manually before setting timeout
Date: Wed, 1 Apr 2020 10:20:32 +0000 [thread overview]
Message-ID: <AM6PR10MB226301829B873FFEFE845FE180C90@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200326150203.371673-3-s.riedmueller@phytec.de>
On 26 March 2020 15:02, Stefan Riedmueller wrote:
> There is actually no need to ping the watchdog before disabling it
> during timeout change. Disabling the watchdog already takes care of
> resetting the counter.
>
> This fixes an issue during boot when the userspace watchdog handler takes
> over and the watchdog is already running. Opening the watchdog in this case
> leads to the first ping and directly after that without the required
> heartbeat delay a second ping issued by the set_timeout call. Due to the
> missing delay this resulted in a reset.
>
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Thanks for the update:
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> drivers/watchdog/da9062_wdt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
> index 6d81b1276b87..c5bd075c8b14 100644
> --- a/drivers/watchdog/da9062_wdt.c
> +++ b/drivers/watchdog/da9062_wdt.c
> @@ -66,11 +66,6 @@ static int da9062_wdt_update_timeout_register(struct
> da9062_watchdog *wdt,
> unsigned int regval)
> {
> struct da9062 *chip = wdt->hw;
> - int ret;
> -
> - ret = da9062_reset_watchdog_timer(wdt);
> - if (ret)
> - return ret;
>
> regmap_update_bits(chip->regmap,
> DA9062AA_CONTROL_D,
> --
> 2.23.0
next prev parent reply other threads:[~2020-04-01 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:02 [PATCH 1/3] watchdog: da9062: Use pre-configured timeout until userspace takes over Stefan Riedmueller
2020-03-26 15:02 ` [PATCH 2/3] watchdog: da9063: Use pre configured timeout when watchdog is running Stefan Riedmueller
2020-03-30 16:38 ` Adam Thomson
2020-03-31 16:08 ` Guenter Roeck
2020-04-01 8:19 ` Stefan Riedmüller
2020-03-26 15:02 ` [PATCH 3/3] watchdog: da9062: No need to ping manually before setting timeout Stefan Riedmueller
2020-03-31 16:11 ` Guenter Roeck
2020-04-01 10:20 ` Adam Thomson [this message]
2020-03-31 16:00 ` [PATCH 1/3] watchdog: da9062: Use pre-configured timeout until userspace takes over Guenter Roeck
2020-03-31 16:04 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR10MB226301829B873FFEFE845FE180C90@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=s.riedmueller@phytec.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).