From: Art Nikpal <email2tema@gmail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: wim@linux-watchdog.org, linux@roeck-us.net,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-kernel@vger.kernel.org, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH] watchdog: meson_gxbb_wdt: improve
Date: Tue, 22 Jun 2021 19:53:21 +0800 [thread overview]
Message-ID: <CAKaHn9JpH2Yh-1njO6jEnFeu-GMhbonftN=-VXdbvjdug16qHA@mail.gmail.com> (raw)
In-Reply-To: <bfa12322-bc49-2337-2988-199e87e34b87@baylibre.com>
> Neil
> Can you split the patch in 4 distinct changes ?
yes no problem i can try to do it tomorrow !
maybe somebody have other ideas, suggestion, comments ...
On Tue, Jun 22, 2021 at 7:08 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Art,
>
> On 22/06/2021 11:56, Artem Lapkin wrote:
> > Improve meson_gxbb_wdt watchdog driver
> > 1) added module param timeout and nowayout same as other modules
> > 2) print watchdog driver start status
> > 3) add watchdog_stop_on_unregister
> > 4) remove watchdog_stop_on_reboot ( still can be activated by
> > watchdog.stop_on_reboot=1 ) i think this driver configuration more useful
> > becouse we can get reboot waranty for abnormal situations on shutdown stage
>
> Can you split the patch in 4 distinct changes ?
>
> Neil
>
> >
> > Signed-off-by: Artem Lapkin <art@khadas.com>
> > ---
> > drivers/watchdog/meson_gxbb_wdt.c | 20 ++++++++++++++++++--
> > 1 file changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
> > index 5a9ca10fbcfa..15c889932c13 100644
> > --- a/drivers/watchdog/meson_gxbb_wdt.c
> > +++ b/drivers/watchdog/meson_gxbb_wdt.c
> > @@ -35,6 +35,17 @@ struct meson_gxbb_wdt {
> > struct clk *clk;
> > };
> >
> > +static bool nowayout = WATCHDOG_NOWAYOUT;
> > +static unsigned int timeout = DEFAULT_TIMEOUT;
> > +
> > +module_param(nowayout, bool, 0);
> > +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default="
> > + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> > +
> > +module_param(timeout, uint, 0);
> > +MODULE_PARM_DESC(timeout, "Watchdog heartbeat in seconds="
> > + __MODULE_STRING(DEFAULT_TIMEOUT) ")");
> > +
> > static int meson_gxbb_wdt_start(struct watchdog_device *wdt_dev)
> > {
> > struct meson_gxbb_wdt *data = watchdog_get_drvdata(wdt_dev);
> > @@ -174,7 +185,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)
> > data->wdt_dev.ops = &meson_gxbb_wdt_ops;
> > data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK;
> > data->wdt_dev.min_timeout = 1;
> > - data->wdt_dev.timeout = DEFAULT_TIMEOUT;
> > + data->wdt_dev.timeout = timeout;
> > watchdog_set_drvdata(&data->wdt_dev, data);
> >
> > /* Setup with 1ms timebase */
> > @@ -186,7 +197,12 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)
> >
> > meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout);
> >
> > - watchdog_stop_on_reboot(&data->wdt_dev);
> > + watchdog_set_nowayout(&data->wdt_dev, nowayout);
> > + watchdog_stop_on_unregister(&data->wdt_dev);
> > +
> > + dev_info(dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)",
> > + data->wdt_dev.timeout, nowayout);
> > +
> > return devm_watchdog_register_device(dev, &data->wdt_dev);
> > }
> >
> >
>
next prev parent reply other threads:[~2021-06-22 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 9:56 [PATCH] watchdog: meson_gxbb_wdt: improve Artem Lapkin
2021-06-22 11:08 ` Neil Armstrong
2021-06-22 11:53 ` Art Nikpal [this message]
2021-06-22 12:43 ` Neil Armstrong
2021-06-22 17:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKaHn9JpH2Yh-1njO6jEnFeu-GMhbonftN=-VXdbvjdug16qHA@mail.gmail.com' \
--to=email2tema@gmail.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).