From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-power@fi.rohmeurope.com,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] watchdog: BD70528: conditionally allow BD70528 module
Date: Fri, 8 Jan 2021 08:34:46 +0200 [thread overview]
Message-ID: <CANhJrGPqqb0WA0efEE0fjMEqaCwJaabyxBx2ucGhvC-JVxt7-w@mail.gmail.com> (raw)
In-Reply-To: <20210107151254.GB13040@roeck-us.net>
On Thu, Jan 7, 2021 at 5:12 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Thu, Jan 07, 2021 at 08:37:25AM +0200, Matti Vaittinen wrote:
> > The BD70528 watchdog module provides start/stop interface for RTC
> > driver because the BD70528 watchdog must be stopped when RTC time
> > is set. (WDG uses RTC counter and setting RTC may accidentally trigger
> > WDG if WDG is enabled). The BD71828 use same RTC driver as BD70528 but
> > don't share same WDG logic. When BD70528 is not configured a stub call
> > to "stop WDG" is implemented and in case when BD71828 is used, this
> > stub function should be called. Prevent configuring in the BD70528
> > watchdog when BD71828 is configured to avoid access to real WDG
> > functions when WDG does not exist in HW.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
>
> As mentioned in my response to the other patch, I think this is the
> wrong solution.
I agree. Please forget this :)
Thanks for the review!
Best Regards
Matti
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-Matti Vaittinen
When you feel blue, no one sees your tears...
When your down, no one understands your struggle...
When you feel happy, no one notices your smile...
But fart just once...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2021-01-08 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 6:37 [PATCH 1/2] watchdog: bd70528: don't crash if WDG is confiured with BD71828 Matti Vaittinen
2021-01-07 6:37 ` [PATCH 2/2] watchdog: BD70528: conditionally allow BD70528 module Matti Vaittinen
2021-01-07 15:12 ` Guenter Roeck
2021-01-08 6:34 ` Matti Vaittinen [this message]
2021-01-07 15:12 ` [PATCH 1/2] watchdog: bd70528: don't crash if WDG is confiured with BD71828 Guenter Roeck
2021-01-07 18:15 ` Vaittinen, Matti
2021-01-08 6:10 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANhJrGPqqb0WA0efEE0fjMEqaCwJaabyxBx2ucGhvC-JVxt7-w@mail.gmail.com \
--to=mazziesaccount@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).