From: Julius Werner <jwerner@chromium.org>
To: Evan Benn <evanbenn@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Julius Werner <jwerner@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Anson Huang <Anson.Huang@nxp.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Vinod Koul <vkoul@kernel.org>, Will Deacon <will@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] watchdog: Add new arm_smd_wdt watchdog driver
Date: Fri, 3 Apr 2020 15:56:40 -0700 [thread overview]
Message-ID: <CAODwPW_iSK_d6EHCk7QUVF7=bHVLuUYHX5mfapf+yeyuHHdNZA@mail.gmail.com> (raw)
In-Reply-To: <20200403162742.v2.2.Ia92bb4d4ce84bcefeba1d00aaa1c1e919b6164ef@changeid>
> + wdd->info = &smcwd_info;
> + /* get_timeleft is optional */
> + if (smcwd_call(SMCWD_GET_TIMELEFT, 0, NULL))
How is this supposed to work? A firmware that implements this call
would return the time left here which may not be 0 (maybe the watchdog
was already primed by the bootloader or whatever), so smcwd_call()
would interpret it as an error.
I think the cleanest solution would be to stick to the same return
codes in a0 and use a1 to report the time left when a0 is
PSCI_SUCCESS. This is more consistent with SMCWD_INIT too.
next prev parent reply other threads:[~2020-04-03 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 5:28 [PATCH v2 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-04-03 5:28 ` [PATCH v2 1/2] dt-bindings: watchdog: Add ARM smc wdt for mt8173 watchdog Evan Benn
2020-04-03 5:29 ` [PATCH v2 2/2] watchdog: Add new arm_smd_wdt watchdog driver Evan Benn
2020-04-03 6:00 ` Guenter Roeck
2020-04-03 22:56 ` Julius Werner [this message]
2020-04-04 1:00 ` Evan Benn
2020-04-03 6:08 ` [PATCH v2 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
[not found] ` <CAKz_xw0gV+w_gMkLfB4qUBdULLfFoiv1TBWp9_PHy33wP_XWyA@mail.gmail.com>
[not found] ` <890948ef-7276-fdae-d270-eb30eff3eab2@amlogic.com>
2020-04-15 11:54 ` Xingyu Chen
2020-04-15 22:29 ` Julius Werner
2020-04-15 23:12 ` Guenter Roeck
2020-04-16 0:46 ` Evan Benn
2020-04-16 0:56 ` Julius Werner
2020-04-16 3:48 ` Florian Fainelli
2020-04-21 1:08 ` Evan Benn
2020-04-21 2:36 ` Florian Fainelli
2020-04-16 3:23 ` Xingyu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAODwPW_iSK_d6EHCk7QUVF7=bHVLuUYHX5mfapf+yeyuHHdNZA@mail.gmail.com' \
--to=jwerner@chromium.org \
--cc=Anson.Huang@nxp.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=evanbenn@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+huawei@kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).