From: Anson Huang <anson.huang@nxp.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Zhang Rui" <rui.zhang@intel.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Ronald Tschalär" <ronald@innovation.ch>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"Linux PM" <linux-pm@vger.kernel.org>,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY
Date: Sat, 7 Mar 2020 03:33:54 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916FCC28C5E49FE571226A3F5E00@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200307025720.GA52231@piout.net>
Hi, Alexandre
> Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for
> KEYBOARD_IMX_SC_KEY
>
> On 07/03/2020 01:36:39+0000, Anson Huang wrote:
> > Hi, Alexandre
> >
> > > Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support
> > > for KEYBOARD_IMX_SC_KEY
> > >
> > > On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote:
> > > > On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov
> > > > <dmitry.torokhov@gmail.com> wrote:
> > > > >
> > > > > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote:
> > > > > > Add COMPILE_TEST support to i.MX SC keyboard driver for better
> > > > > > compile testing coverage.
> > > > > >
> > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > > >
> > > > > Applied, thank you.
> > > >
> > > > Actually, not:
> > > >
> > > > ERROR: "imx_scu_irq_register_notifier"
> > > > [drivers/input/keyboard/imx_sc_key.ko] undefined!
> > > > ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko]
> > > undefined!
> > > > ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko]
> > > undefined!
> > > > ERROR: "imx_scu_irq_unregister_notifier"
> > > > [drivers/input/keyboard/imx_sc_key.ko] undefined!
> > > > ERROR: "imx_scu_irq_group_enable"
> > > > [drivers/input/keyboard/imx_sc_key.ko] undefined!
> > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> > > > make: *** [Makefile:1282: modules] Error 2
> > > >
> > > > If you want to enable compile test coverage you need to provide
> > > > stubs for the above functions.
> > > >
> > >
> > > or select IMX_SCU
> > >
> > > or leave out COMPILE_TEST from the individual drivers as having
> > > COMPILE_TEST for IMX_SCU is enough to be able to select the drivers.
> >
> > Thanks, I already added the COMPILE_TEST for IMX_SCU which is in this
> > same patch series, without that IMX_SCU COMPILE_TEST patch, the build
> > will failed, so in V2, I also added the stubs into those IMX SCU APIs
> > to make sure even IMX_SCU is NOT enabled, modules with COMPILE_TEST
> can still pass build, please help review V2 patch set.
> >
>
> My point is that there is no need for the stubs. Simply have COMPILE_TEST
> for IMX_SCU as this is enough to extend coverage to all the drivers and
> significantly reduces the code size versus what you did in v2.
OK, then I think V1 patch set is already what you expected, patch 1/5 adds the COMPILE_TEST
for IMX_SCU. I think maintainers can just pick up the V1 patch set.
Thanks,
Anson
next prev parent reply other threads:[~2020-03-07 3:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 15:42 [PATCH 1/5] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-06 15:42 ` [PATCH 2/5] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-06 15:42 ` [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-06 19:33 ` Dmitry Torokhov
2020-03-06 20:05 ` Dmitry Torokhov
2020-03-06 21:15 ` Alexandre Belloni
2020-03-07 1:36 ` Anson Huang
2020-03-07 2:57 ` Alexandre Belloni
2020-03-07 3:33 ` Anson Huang [this message]
2020-03-07 0:18 ` Anson Huang
2020-03-07 0:51 ` Dmitry Torokhov
2020-03-07 1:01 ` Anson Huang
2020-03-06 15:42 ` [PATCH 4/5] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-06 15:42 ` [PATCH 5/5] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-06 16:38 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916FCC28C5E49FE571226A3F5E00@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=linux@roeck-us.net \
--cc=m.felsch@pengutronix.de \
--cc=ronald@innovation.ch \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).