linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ayyathurai, Vijayakannan" <vijayakannan.ayyathurai@intel.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"andriy.shevchenko@linux.intel.com" 
	<andriy.shevchenko@linux.intel.com>,
	"mgross@linux.intel.com" <mgross@linux.intel.com>,
	"Wan Mohamad,
	Wan Ahmad Zainie"  <wan.ahmad.zainie.wan.mohamad@intel.com>,
	"Raja Subramanian,
	Lakshmi Bai"  <lakshmi.bai.raja.subramanian@intel.com>,
	"Seow, Chen Yong" <chen.yong.seow@intel.com>
Subject: RE: [PATCH v4 0/2] Add drivers for Intel Keem Bay SoC watchdog
Date: Wed, 13 Jan 2021 10:59:31 +0000	[thread overview]
Message-ID: <DM6PR11MB42506A488FD9A54BAD3824CCFBA90@DM6PR11MB4250.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cover.1608141131.git.vijayakannan.ayyathurai@intel.com>

Hi,

> From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
> 
> Changes since v3:
>  - Fix pretimeout clear, when user attempt in the below sequence.
> 	- set pretimeout
> 	- clear pretimeout
> 	- set timeout to some other value
>  - Cleanup the ping variable usage in the driver.
>  - Add keembay_wdt_set_timeout_reg function.
>  - Cleanup the keembay_wdt_th_isr function.
>  - Rebase the driver with 5.10-rc7 tag.
> 

Kindly help us to review this updated patch(v4) set.

Thanks,
Vijay

> Changes since v2:
>  - Remove reduntant write to TIM_WATCHDOG as per Guenter.
>  - Rebase the driver with 5.10-rc5 tag.
> 
> Changes since v1:
>  - Fix indentation error in the dt-bindings file.
>  - Use true/false in the second arg of keembay_wdt_set_timeout_reg().
>  - Fix the watchdog start sequence.
>  - Avoid reduntant timeout register setting.
>  - Remove min usage to find actual time at keembay_wdt_set_timeout().
>  - Remove timeout configuration boundary check at
>    keembay_wdt_set_pretimeout().
>  - Use devm_watchdog_register_device() for wdt registration, which
>    eventually supports driver unload functionality as well.
> 

      parent reply	other threads:[~2021-01-13 11:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 18:32 [PATCH v4 0/2] Add drivers for Intel Keem Bay SoC watchdog vijayakannan.ayyathurai
2020-12-16 18:32 ` [PATCH v4 1/2] dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC vijayakannan.ayyathurai
2021-01-23 17:18   ` Guenter Roeck
2021-01-25  2:56     ` Ayyathurai, Vijayakannan
2020-12-16 18:32 ` [PATCH v4 2/2] watchdog: Add watchdog driver for Intel Keembay Soc vijayakannan.ayyathurai
2021-01-23 17:18   ` Guenter Roeck
2021-01-25  2:57     ` Ayyathurai, Vijayakannan
2020-12-30  7:17 ` [PATCH v4 0/2] Add drivers for Intel Keem Bay SoC watchdog Ayyathurai, Vijayakannan
2021-01-13 10:59 ` Ayyathurai, Vijayakannan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB42506A488FD9A54BAD3824CCFBA90@DM6PR11MB4250.namprd11.prod.outlook.com \
    --to=vijayakannan.ayyathurai@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=chen.yong.seow@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lakshmi.bai.raja.subramanian@intel.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mgross@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=wan.ahmad.zainie.wan.mohamad@intel.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).