From: Biju Das <biju.das.jz@bp.renesas.com>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v1 3/3] watchdog: Add Watchdog Timer driver for RZ/G2L
Date: Thu, 11 Nov 2021 11:00:48 +0000 [thread overview]
Message-ID: <OS0PR01MB59226D0ABF892D1D3D20D5E086949@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <24319fb4-cc3a-1923-7238-db42ed93e51e@roeck-us.net>
> Subject: Re: [PATCH v1 3/3] watchdog: Add Watchdog Timer driver for RZ/G2L
>
> On 11/11/21 2:35 AM, Biju Das wrote:
> [ ... [
> >>> +
> >>> + ret = devm_add_action_or_reset(&pdev->dev,
> >>> + rzg2l_wdt_reset_assert_pm_disable_put,
> >>> + &priv->wdev);
> >>> + if (ret < 0)
> >>> + goto out_reset;
> >>
> >> _or_reset implies that the action is taken on failure, so there is
> >> not need to do it again.
> >
> > As per [1], it can return -ENOMEM, in that case I don't get action
> > callback. On a safer side I will move this call after
> > watchdog_set_drvdata()
> >
>
> That points to devm_add_action(), not to devm_add_action_or_reset().
Ah got it. action will taken on failure.
Thanks,
Biju
prev parent reply other threads:[~2021-11-11 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 8:52 [PATCH v1 0/3] Add WDT driver for RZ/G2L Biju Das
2021-11-11 8:52 ` [PATCH v1 1/3] clk: renesas: rzg2l: Add support for watchdog reset selection Biju Das
2021-11-11 8:52 ` [PATCH v1 2/3] dt-bindings: watchdog: renesas,wdt: Add support for RZ/G2L Biju Das
2021-11-11 8:52 ` [PATCH v1 3/3] watchdog: Add Watchdog Timer driver " Biju Das
2021-11-11 9:27 ` Biju Das
2021-11-11 10:21 ` Guenter Roeck
2021-11-11 10:35 ` Biju Das
2021-11-11 10:50 ` Guenter Roeck
2021-11-11 11:00 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59226D0ABF892D1D3D20D5E086949@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).