Re: [PATCH V2 2/2] dt-bindings: mfd: add Broadcom's Timer-Watchdog block

[Rob Herring <robh@kernel.org>]

On Tue, Nov 02, 2021 at 05:06:15PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> It's a block implementing few time related functions depending on a
> (SoC specific) variant. At this point there is ready binding for a
> watchdog only. Work on remaining subblocks (e.g. "reg" based reboot) is
> in progress.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Update $id, description, compatible, example & commit message
> ---
>  .../devicetree/bindings/mfd/brcm,twd.yaml     | 62 +++++++++++++++++++
>  1 file changed, 62 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/brcm,twd.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/brcm,twd.yaml b/Documentation/devicetree/bindings/mfd/brcm,twd.yaml
> new file mode 100644
> index 000000000000..ed167055be06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/brcm,twd.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/brcm,twd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom's Timer-Watchdog (aka TWD)
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@milecki.pl>
> +
> +description: |
> +  Broadcom has a Timer-Watchdog block used in multiple SoCs (e.g., BCM4908,
> +  BCM63xx, BCM7038). There are few variants available (they differ slightly in
> +  registers layout). This block consists of: timers, watchdog and optionally a
> +  software reset handler.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +        - brcm,bcm4908-twd
> +        - brcm,bcm7038-twd
> +      - const: brcm,twd

I don't think you need this given you don't expect to have a driver for 
this other than syscon driver.

> +      - const: simple-mfd
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  ranges: true
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +patternProperties:
> +  '^watchdog@[a-f0-9]+$':
> +    $ref: /schemas/watchdog/brcm,bcm7038-wdt.yaml
> +
> +additionalProperties: false
> +
> +required:
> +  - reg
> +
> +examples:
> +  - |
> +    timer-mfd@ff800400 {
> +        compatible = "brcm,bcm4908-twd", "brcm,twd", "simple-mfd", "syscon";
> +        reg = <0xff800400 0x4c>;
> +        ranges = <0x00000000 0xff800400 0x4c>;
> +
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        watchdog@28 {
> +            compatible = "brcm,bcm7038-wdt";
> +            reg = <0x28 0x8>;
> +        };
> +    };
> -- 
> 2.31.1
> 
>