From: Guenter Roeck <linux@roeck-us.net>
To: michaelsh@mellanox.com, wim@linux-watchdog.org,
andy@infradead.org, dvhart@infradead.org
Cc: linux-watchdog@vger.kernel.org,
platform-driver-x86@vger.kernel.org, vadimp@mellanox.com
Subject: Re: [PATCH v2 1/3] platform_data/mlxreg: addittions for mellanox watchdog driver.
Date: Mon, 18 Feb 2019 08:12:41 -0800 [thread overview]
Message-ID: <a48b4759-c0c1-b2df-0e98-99d39f9b4161@roeck-us.net> (raw)
In-Reply-To: <20190207211053.10766-2-michaelsh@mellanox.com>
On 2/7/19 1:10 PM, michaelsh@mellanox.com wrote:
> From: Michael Shych <michaelsh@mellanox.com>
>
> There are two new fields added to mlxreg core structure:
> features - supported features of device and
> identity - device identity name.
> Add new defines for watchdog features.
>
> Signed-off-by: Michael Shych <michaelsh@mellanox.com>
>
Subject: s/addittions/additions/
Otherwise
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v1->v2
> Change feature name MLXREG_CORE_WD_FEATURE_NOSTOP_AFTER_START
> to MLXREG_CORE_WD_FEATURE_NOWAYOUT
> ---
> include/linux/platform_data/mlxreg.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/platform_data/mlxreg.h b/include/linux/platform_data/mlxreg.h
> index 19f5cb618c55..aadc80700573 100644
> --- a/include/linux/platform_data/mlxreg.h
> +++ b/include/linux/platform_data/mlxreg.h
> @@ -35,6 +35,8 @@
> #define __LINUX_PLATFORM_DATA_MLXREG_H
>
> #define MLXREG_CORE_LABEL_MAX_SIZE 32
> +#define MLXREG_CORE_WD_FEATURE_NOWAYOUT BIT(0)
> +#define MLXREG_CORE_WD_FEATURE_START_AT_BOOT BIT(1)
>
> /**
> * struct mlxreg_hotplug_device - I2C device data:
> @@ -110,11 +112,15 @@ struct mlxreg_core_item {
> * @led_data: led private data;
> * @regmap: register map of parent device;
> * @counter: number of led instances;
> + * @features: supported features of device;
> + * @identity: device identity name;
> */
> struct mlxreg_core_platform_data {
> struct mlxreg_core_data *data;
> void *regmap;
> int counter;
> + u32 features;
> + char identity[MLXREG_CORE_LABEL_MAX_SIZE];
> };
>
> /**
>
next prev parent reply other threads:[~2019-02-18 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 21:10 [PATCH v2 0/3] introduce watchdog driver for Mellanox systems michaelsh
2019-02-07 21:10 ` [PATCH v2 1/3] platform_data/mlxreg: addittions for mellanox watchdog driver michaelsh
2019-02-18 16:12 ` Guenter Roeck [this message]
2019-02-07 21:10 ` [PATCH v2 2/3] watchdog: mlx-wdt: introduce watchdog driver for Mellanox systems michaelsh
2019-02-18 16:26 ` Guenter Roeck
2019-02-19 17:00 ` Michael Shych
2019-02-19 17:46 ` Guenter Roeck
2019-02-07 21:10 ` [PATCH v2 3/3] Documentation/watchdog: Add documentation mlx-wdt driver michaelsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48b4759-c0c1-b2df-0e98-99d39f9b4161@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).