From: "Andreas Färber" <afaerber@suse.de>
To: Rob Herring <robh@kernel.org>
Cc: linux-realtek-soc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] dt-bindings: watchdog: realtek: Convert RTD119x to schema
Date: Fri, 25 Oct 2019 23:24:07 +0200 [thread overview]
Message-ID: <aeb0d0ed-5649-9035-c753-39e8a1511c9d@suse.de> (raw)
In-Reply-To: <20191025211638.GA28819@bogus>
Am 25.10.19 um 23:16 schrieb Rob Herring:
> On Sun, Oct 20, 2019 at 06:08:10AM +0200, Andreas Färber wrote:
>> Convert the Realtek watchdog binding to a YAML schema.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>> v2: New
>>
>> .../bindings/watchdog/realtek,rtd119x.txt | 17 ----------
>> .../bindings/watchdog/realtek,rtd119x.yaml | 38 ++++++++++++++++++++++
>> 2 files changed, 38 insertions(+), 17 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
>> create mode 100644 Documentation/devicetree/bindings/watchdog/realtek,rtd119x.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
>> deleted file mode 100644
>> index 05653054bd5b..000000000000
>> --- a/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
>> +++ /dev/null
>> @@ -1,17 +0,0 @@
>> -Realtek RTD1295 Watchdog
>> -========================
>> -
>> -Required properties:
>> -
>> -- compatible : Should be "realtek,rtd1295-watchdog"
>> -- reg : Specifies the physical base address and size of registers
>> -- clocks : Specifies one clock input
>> -
>> -
>> -Example:
>> -
>> - watchdog@98007680 {
>> - compatible = "realtek,rtd1295-watchdog";
>> - reg = <0x98007680 0x100>;
>> - clocks = <&osc27M>;
>> - };
>> diff --git a/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.yaml b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.yaml
>> new file mode 100644
>> index 000000000000..5d92cfdfd046
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/watchdog/realtek,rtd119x.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Realtek RTD1295 Watchdog
>> +
>> +maintainers:
>> + - Andreas Färber <afaerber@suse.de>
>> +
>> +allOf:
>> + - $ref: watchdog.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: realtek,rtd1295-watchdog
>
> You can drop the 'oneOf' here unless you're planning to add another
> entry with 2 compatible strings.
It's a preparation for adding rtd1195-watchdog when needed, to make
future diffs smaller. There's also RTD1395 and RTD1619 to be tested.
>
> With that,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Thanks,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2019-10-25 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191020040817.16882-1-afaerber@suse.de>
2019-10-20 4:08 ` [PATCH v2 1/8] dt-bindings: watchdog: realtek: Convert RTD119x to schema Andreas Färber
2019-10-25 21:16 ` Rob Herring
2019-10-25 21:24 ` Andreas Färber [this message]
2019-10-27 2:04 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb0d0ed-5649-9035-c753-39e8a1511c9d@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).