From: Aswath Govindraju <a-govindraju@ti.com>
To: Rob Herring <robh@kernel.org>, <devicetree@vger.kernel.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Marek <jonathan@marek.ca>, Marc Zyngier <maz@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-spi@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: More use 'enum' instead of 'oneOf' plus 'const' entries
Date: Mon, 13 Sep 2021 10:02:55 +0530 [thread overview]
Message-ID: <b56ee1c2-ce2d-a3ed-ff54-7b0d956f959a@ti.com> (raw)
In-Reply-To: <20210910165153.2843871-1-robh@kernel.org>
On 10/09/21 10:21 pm, Rob Herring wrote:
> 'enum' is equivalent to 'oneOf' with a list of 'const' entries, but 'enum'
> is more concise and yields better error messages.
>
> Fix a couple more cases which have appeared.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jonathan Marek <jonathan@marek.ca>
> Cc: Aswath Govindraju <a-govindraju@ti.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Cc: linux-spi@vger.kernel.org
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/display/msm/dsi-phy-7nm.yaml | 8 ++++----
> .../devicetree/bindings/spi/omap-spi.yaml | 6 +++---
For omap-spi:
Acked-by: Aswath Govindraju <a-govindraju@ti.com>
> .../bindings/watchdog/maxim,max63xx.yaml | 14 +++++++-------
> 3 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> index 4265399bb154..c851770bbdf2 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> @@ -14,10 +14,10 @@ allOf:
>
> properties:
> compatible:
> - oneOf:
> - - const: qcom,dsi-phy-7nm
> - - const: qcom,dsi-phy-7nm-8150
> - - const: qcom,sc7280-dsi-phy-7nm
> + enum:
> + - qcom,dsi-phy-7nm
> + - qcom,dsi-phy-7nm-8150
> + - qcom,sc7280-dsi-phy-7nm
>
> reg:
> items:
> diff --git a/Documentation/devicetree/bindings/spi/omap-spi.yaml b/Documentation/devicetree/bindings/spi/omap-spi.yaml
> index e55538186cf6..9952199cae11 100644
> --- a/Documentation/devicetree/bindings/spi/omap-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/omap-spi.yaml
> @@ -84,9 +84,9 @@ unevaluatedProperties: false
> if:
> properties:
> compatible:
> - oneOf:
> - - const: ti,omap2-mcspi
> - - const: ti,omap4-mcspi
> + enum:
> + - ti,omap2-mcspi
> + - ti,omap4-mcspi
>
> then:
> properties:
> diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> index f2105eedac2c..ab9641e845db 100644
> --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> @@ -15,13 +15,13 @@ maintainers:
>
> properties:
> compatible:
> - oneOf:
> - - const: maxim,max6369
> - - const: maxim,max6370
> - - const: maxim,max6371
> - - const: maxim,max6372
> - - const: maxim,max6373
> - - const: maxim,max6374
> + enum:
> + - maxim,max6369
> + - maxim,max6370
> + - maxim,max6371
> + - maxim,max6372
> + - maxim,max6373
> + - maxim,max6374
>
> reg:
> description: This is a 1-byte memory-mapped address
>
prev parent reply other threads:[~2021-09-13 4:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:51 [PATCH] dt-bindings: More use 'enum' instead of 'oneOf' plus 'const' entries Rob Herring
2021-09-10 16:54 ` Mark Brown
2021-09-10 17:11 ` Guenter Roeck
2021-09-13 4:32 ` Aswath Govindraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b56ee1c2-ce2d-a3ed-ff54-7b0d956f959a@ti.com \
--to=a-govindraju@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).