From: Guenter Roeck <linux@roeck-us.net>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>,
linux-watchdog@vger.kernel.org,
Matthias Kaehlcke <mka@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] watchdog: qcom: Use platform_get_irq_optional() for bark irq
Date: Fri, 13 Dec 2019 05:51:33 -0800 [thread overview]
Message-ID: <b5b1d073-832b-e7bf-90b0-0cd4167ca3dc@roeck-us.net> (raw)
In-Reply-To: <20191213064934.4112-1-saiprakash.ranjan@codeaurora.org>
On 12/12/19 10:49 PM, Sai Prakash Ranjan wrote:
> platform_get_irq() prints an error message when the interrupt
> is not available. So on platforms where bark interrupt is
> not specified, following error message is observed on SDM845.
>
> [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found
>
> This is also seen on SC7180, SM8150 SoCs as well.
> Fix this by using platform_get_irq_optional() instead.
>
> Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available")
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/qcom-wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c
> index a494543d3ae1..eb47fe5ed280 100644
> --- a/drivers/watchdog/qcom-wdt.c
> +++ b/drivers/watchdog/qcom-wdt.c
> @@ -246,7 +246,7 @@ static int qcom_wdt_probe(struct platform_device *pdev)
> }
>
> /* check if there is pretimeout support */
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq > 0) {
> ret = devm_request_irq(dev, irq, qcom_wdt_isr,
> IRQF_TRIGGER_RISING,
>
next prev parent reply other threads:[~2019-12-13 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 6:49 [PATCH] watchdog: qcom: Use platform_get_irq_optional() for bark irq Sai Prakash Ranjan
2019-12-13 7:15 ` Bjorn Andersson
2019-12-13 13:51 ` Guenter Roeck [this message]
2019-12-16 16:48 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b1d073-832b-e7bf-90b0-0cd4167ca3dc@roeck-us.net \
--to=linux@roeck-us.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mka@chromium.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).