linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Balantzyan <mbalant3@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	wim@linux-watchdog.org
Subject: Re: [PATCH] watchdog device drivers:pc87413_wdt: Rewriting of pc87413_wdt driver to utilize common watchdog interface (fwd)
Date: Mon, 29 Jul 2019 18:30:48 -0700	[thread overview]
Message-ID: <c28680b5-d262-97ae-5bdc-5cce9169e2da@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.21.1907291732130.20898@mbalantz-desktop>

Mark,

On 7/29/19 5:44 PM, Mark Balantzyan wrote:
> Hello all, Guenter,
> 
> I am being evaluated as a student by my organization. I appreciate your patience with my emails and patches.
> 
> I would like to please propose that we divide and conquer: I write the code for converting the driver to common watchdog interface (and I thank you for your guidance on it in previous email) and you test the code on the actual hardware you may happen to have, as I do not have it. I accept the fact that it is indeed risky without the hardware to ensure the driver works correctly, but that will be where we work in tandem, software to hardware, yes, if that's alright?
> 

If I had the hardware, I would say so. Then we would have no problem,
I would thank you for your work, and I would be more than happy to test
your patch on that hardware.

Unfortunately, I don't have the hardware, and I don't know anyone who (still)
has. The most recent functional change to this driver was made back in 2011.

If the task is to convert a watchdog driver, does it have to be _this_ driver ?
One that comes into mind instead would be ib700, which looks to be quite similar
and which _is_ supported by qemu. I have not tried if its qemu emulation
actually works, but it would be worth a try.

The only alternative I can see, if it has to be _this_ driver for some reason,
is for us to go through with it and then let the patch hang around until we
find someone to test it (which may be never). I am not really sure if that
would be worth our time.

> I think it's better if I use git send-email for the corresponding patch with the improvements you forecasted since it may format things better and may result in a non-corrupted patching.
> 
Most definitely, yes.

Thanks,
Guenter

  reply	other threads:[~2019-07-30  1:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 23:17 [PATCH] watchdog device drivers:pc87413_wdt: Rewriting of pc87413_wdt driver to utilize common watchdog interface (fwd) Mark Balantzyan
2019-07-30  0:26 ` Guenter Roeck
2019-07-30  0:44   ` Mark Balantzyan
2019-07-30  1:30     ` Guenter Roeck [this message]
2019-07-30  2:21       ` Mark Balantzyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c28680b5-d262-97ae-5bdc-5cce9169e2da@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mbalant3@gmail.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).