From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>, John Crispin <john@phrozen.org>,
linux-mips@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] MIPS: ralink: export rt_sysc_membase for rt2880_wdt.c
Date: Sun, 16 May 2021 22:06:31 -0700 [thread overview]
Message-ID: <e56fa6d9-1305-b3c5-d385-37042835686c@roeck-us.net> (raw)
In-Reply-To: <20210517005417.18338-1-rdunlap@infradead.org>
On 5/16/21 5:54 PM, Randy Dunlap wrote:
> rt2880_wdt.c uses (well, attempts to use) rt_sysc_membase. However,
> when this watchdog driver is built as a loadable module, there is a
> build error since the rt_sysc_membase symbol is not exported.
> Export it to quell the build error.
>
> ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>
> Fixes: 473cf939ff34 ("watchdog: add ralink watchdog driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Wim Van Sebroeck <wim@iguana.be>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> Cc: John Crispin <john@phrozen.org>
> Cc: linux-mips@vger.kernel.org
> Cc: linux-watchdog@vger.kernel.org
> ---
> or make the Kconfig symbol RALINK_WDT bool instead of tristate?
>
You'd have to change several other config symbols to boolean as well.
Example with PHY_MT7621_PCI=m:
ERROR: modpost: "rt_sysc_membase" [drivers/phy/ralink/phy-mt7621-pci.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
Same with MT7621_WDT=m.
ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/mt7621_wdt.ko] undefined!
At that point I stopped looking.
Guenter
> arch/mips/ralink/of.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20210514.orig/arch/mips/ralink/of.c
> +++ linux-next-20210514/arch/mips/ralink/of.c
> @@ -8,6 +8,7 @@
>
> #include <linux/io.h>
> #include <linux/clk.h>
> +#include <linux/export.h>
> #include <linux/init.h>
> #include <linux/sizes.h>
> #include <linux/of_fdt.h>
> @@ -25,6 +26,7 @@
>
> __iomem void *rt_sysc_membase;
> __iomem void *rt_memc_membase;
> +EXPORT_SYMBOL_GPL(rt_sysc_membase);
>
> __iomem void *plat_of_remap_node(const char *node)
> {
>
next prev parent reply other threads:[~2021-05-17 5:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 0:54 [PATCH] MIPS: ralink: export rt_sysc_membase for rt2880_wdt.c Randy Dunlap
2021-05-17 5:06 ` Guenter Roeck [this message]
2021-05-17 6:31 ` Sergio Paracuellos
2021-05-25 13:39 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56fa6d9-1305-b3c5-d385-37042835686c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).