From: Guenter Roeck <linux@roeck-us.net>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: it87_wdt: remove useless function
Date: Tue, 13 Apr 2021 08:01:08 -0700 [thread overview]
Message-ID: <e57ade58-e4b3-e872-c8e7-097ced9635c9@roeck-us.net> (raw)
In-Reply-To: <1618306460-57286-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On 4/13/21 2:34 AM, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/watchdog/it87_wdt.c:155:20: warning: unused function
> 'superio_outw' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/it87_wdt.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index 2b48318..bb11229 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -152,14 +152,6 @@ static inline int superio_inw(int reg)
> return val;
> }
>
> -static inline void superio_outw(int val, int reg)
> -{
> - outb(reg++, REG);
> - outb(val >> 8, VAL);
> - outb(reg, REG);
> - outb(val, VAL);
> -}
> -
> /* Internal function, should be called after superio_select(GPIO) */
> static void _wdt_update_timeout(unsigned int t)
> {
>
prev parent reply other threads:[~2021-04-13 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 9:34 [PATCH] watchdog: it87_wdt: remove useless function Jiapeng Chong
2021-04-13 15:01 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57ade58-e4b3-e872-c8e7-097ced9635c9@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).