From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: kbuild test robot <lkp@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: kbuild-all@lists.01.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: make nowayout sysfs file writable
Date: Wed, 6 Nov 2019 08:44:33 +0100 [thread overview]
Message-ID: <fdc909d7-bf73-740e-0da0-1aad41806734@rasmusvillemoes.dk> (raw)
In-Reply-To: <201911060551.VIFgN8pe%lkp@intel.com>
On 05/11/2019 22.16, kbuild test robot wrote:
> In file included from include/linux/mutex.h:14:0,
> from include/linux/kernfs.h:12,
> from include/linux/sysfs.h:16,
> from include/linux/kobject.h:20,
> from include/linux/cdev.h:5,
> from drivers/watchdog/watchdog_dev.c:31:
> drivers/watchdog/watchdog_dev.c: In function 'nowayout_store':
>>> arch/ia64/include/asm/current.h:16:19: error: expected identifier or '(' before 'struct'
> #define current ((struct task_struct *) ia64_getreg(_IA64_REG_TP))
> ^
> drivers/watchdog/watchdog_dev.c:460:22: note: in expansion of macro 'current'
> unsigned int value, current;
> ^~~~~~~
:facecpalm:
And it happened to work just fine in my test because I was targeting
ppc32 where unlike most other arches, current is not a macro but a
(more-or-less) ordinary global declaration
register struct task_struct *current asm ("r2");
Oh well, already fixed in v2 which dropped current for other reasons.
Rasmus
prev parent reply other threads:[~2019-11-06 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 12:31 [PATCH] watchdog: make nowayout sysfs file writable Rasmus Villemoes
2019-11-05 14:22 ` Guenter Roeck
2019-11-05 20:51 ` [PATCH v2] " Rasmus Villemoes
2019-11-06 14:37 ` Guenter Roeck
2019-11-05 21:16 ` [PATCH] " kbuild test robot
2019-11-06 7:44 ` Rasmus Villemoes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdc909d7-bf73-740e-0da0-1aad41806734@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).