From: akolli@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Jouni Malinen <jouni@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] ath11k: use hw_params to access board_size and cal_offset
Date: Mon, 27 Sep 2021 09:51:59 +0530 [thread overview]
Message-ID: <03d382622d9d8a48b35b923d16ca5710@codeaurora.org> (raw)
In-Reply-To: <87a6k2rptc.fsf@codeaurora.org>
On 2021-09-24 20:19, Kalle Valo wrote:
> Jouni Malinen <jouni@codeaurora.org> writes:
>
>> From: Anilkumar Kolli <akolli@codeaurora.org>
>>
>> Reuse board_size from hw_params, add cal_offset to hw params.
>> This patch is clean up only, there is no change in functionality.
>>
>> Tested-on: IPQ8074 hw2.0 AHB
>> WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9074 hw1.0 PCI
>> WLAN.HK.2.4.0.1-01838-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
>> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath11k/core.c | 10 +++++-----
>> drivers/net/wireless/ath/ath11k/hw.h | 2 +-
>> drivers/net/wireless/ath/ath11k/qmi.c | 4 ++--
>> drivers/net/wireless/ath/ath11k/qmi.h | 2 --
>> 4 files changed, 8 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/core.c
>> b/drivers/net/wireless/ath/ath11k/core.c
>> index c97830633f1f..d2ab3b134632 100644
>> --- a/drivers/net/wireless/ath/ath11k/core.c
>> +++ b/drivers/net/wireless/ath/ath11k/core.c
>> @@ -37,7 +37,7 @@ static const struct ath11k_hw_params
>> ath11k_hw_params[] = {
>> .fw = {
>> .dir = "IPQ8074/hw2.0",
>> .board_size = 256 * 1024,
>> - .cal_size = 256 * 1024,
>> + .cal_offset = 128 * 1024,
>> },
>> .max_radios = 3,
>> .bdf_addr = 0x4B0C0000,
>> @@ -87,7 +87,7 @@ static const struct ath11k_hw_params
>> ath11k_hw_params[] = {
>> .fw = {
>> .dir = "IPQ6018/hw1.0",
>> .board_size = 256 * 1024,
>> - .cal_size = 256 * 1024,
>> + .cal_offset = 128 * 1024,
>> },
>> .max_radios = 2,
>> .bdf_addr = 0x4ABC0000,
>> @@ -134,7 +134,7 @@ static const struct ath11k_hw_params
>> ath11k_hw_params[] = {
>> .fw = {
>> .dir = "QCA6390/hw2.0",
>> .board_size = 256 * 1024,
>> - .cal_size = 256 * 1024,
>> + .cal_offset = 128 * 1024,
>> },
>> .max_radios = 3,
>> .bdf_addr = 0x4B0C0000,
>> @@ -180,7 +180,7 @@ static const struct ath11k_hw_params
>> ath11k_hw_params[] = {
>> .fw = {
>> .dir = "QCN9074/hw1.0",
>> .board_size = 256 * 1024,
>> - .cal_size = 256 * 1024,
>> + .cal_offset = 128 * 1024,
>> },
>> .max_radios = 1,
>> .single_pdev_only = false,
>> @@ -226,7 +226,7 @@ static const struct ath11k_hw_params
>> ath11k_hw_params[] = {
>> .fw = {
>> .dir = "WCN6855/hw2.0",
>> .board_size = 256 * 1024,
>> - .cal_size = 256 * 1024,
>> + .cal_offset = 128 * 1024,
>> },
>> .max_radios = 3,
>> .bdf_addr = 0x4B0C0000,
>> diff --git a/drivers/net/wireless/ath/ath11k/hw.h
>> b/drivers/net/wireless/ath/ath11k/hw.h
>> index 5d150cd793b2..3a03e09563e7 100644
>> --- a/drivers/net/wireless/ath/ath11k/hw.h
>> +++ b/drivers/net/wireless/ath/ath11k/hw.h
>> @@ -128,7 +128,7 @@ struct ath11k_hw_params {
>> struct {
>> const char *dir;
>> size_t board_size;
>> - size_t cal_size;
>> + size_t cal_offset;
>
> You don't mention anything about cal_size. I'll add this to the commit
> log:
>
> cal_size was unused, so remove that.
Yes. Thanks for adding.
- Anil.
next prev parent reply other threads:[~2021-09-27 4:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 20:19 [PATCH 0/4] ath11k: Add caldata download support from file/EEPROM Jouni Malinen
2021-07-21 20:19 ` [PATCH 1/4] ath11k: use hw_params to access board_size and cal_offset Jouni Malinen
2021-09-24 14:49 ` Kalle Valo
2021-09-27 4:21 ` akolli [this message]
2021-09-28 10:50 ` Kalle Valo
2021-07-21 20:19 ` [PATCH 2/4] ath11k: clean up BDF download functions Jouni Malinen
2021-07-21 20:19 ` [PATCH 3/4] ath11k: add caldata file for multiple radios Jouni Malinen
2021-07-21 20:19 ` [PATCH 4/4] ath11k: add caldata download support from EEPROM Jouni Malinen
2021-09-24 15:04 ` Kalle Valo
2021-09-27 4:42 ` Anilkumar Kolli
2021-09-28 9:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03d382622d9d8a48b35b923d16ca5710@codeaurora.org \
--to=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).