From: "zhengbin (A)" <zhengbin13@huawei.com>
To: <yhchuang@realtek.com>, <pkshih@realtek.com>,
<kvalo@codeaurora.org>, <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val'
Date: Tue, 8 Oct 2019 17:33:51 +0800 [thread overview]
Message-ID: <08492ba6-eaf6-8c72-74fe-f49e0a95639e@huawei.com> (raw)
In-Reply-To: <1570180736-133907-1-git-send-email-zhengbin13@huawei.com>
Sorry for the noise, please ignore this
On 2019/10/4 17:18, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function rtw8822c_dpk_dc_corr_check:
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable corr_val set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 5227c2ee453d ("rtw88:
> 8822c: add SW DPK support")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8822c.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> index a300efd..52682d5 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> @@ -2163,7 +2163,7 @@ static void rtw8822c_dpk_rxbb_dc_cal(struct rtw_dev *rtwdev, u8 path)
> static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
> {
> u16 dc_i, dc_q;
> - u8 corr_val, corr_idx;
> + u8 corr_idx;
>
> rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000900f0);
> dc_i = (u16)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(27, 16));
> @@ -2176,7 +2176,6 @@ static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
>
> rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000000f0);
> corr_idx = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(7, 0));
> - corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8));
>
> if (dc_i > 200 || dc_q > 200 || corr_idx < 40 || corr_idx > 65)
> return 1;
> --
> 2.7.4
>
>
> .
>
next prev parent reply other threads:[~2019-10-08 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 9:18 [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val' zhengbin
2019-10-08 9:33 ` zhengbin (A) [this message]
2019-10-08 14:24 ` Kalle Valo
2019-10-09 0:17 ` zhengbin (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08492ba6-eaf6-8c72-74fe-f49e0a95639e@huawei.com \
--to=zhengbin13@huawei.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).