From: Kalle Valo <kvalo@codeaurora.org>
To: "zhengbin \(A\)" <zhengbin13@huawei.com>
Cc: <yhchuang@realtek.com>, <pkshih@realtek.com>,
<davem@davemloft.net>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val'
Date: Tue, 08 Oct 2019 17:24:56 +0300 [thread overview]
Message-ID: <87d0f771s7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <08492ba6-eaf6-8c72-74fe-f49e0a95639e@huawei.com> (zhengbin's message of "Tue, 8 Oct 2019 17:33:51 +0800")
(PLEASE don't top post, fixing that manually)
"zhengbin (A)" <zhengbin13@huawei.com> writes:
>
> On 2019/10/4 17:18, zhengbin wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function rtw8822c_dpk_dc_corr_check:
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable corr_val set but not used [-Wunused-but-set-variable]
>>
>> It is not used since commit 5227c2ee453d ("rtw88:
>> 8822c: add SW DPK support")
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>
> Sorry for the noise, please ignore this
Why? What was wrong in the patch?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-08 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 9:18 [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val' zhengbin
2019-10-08 9:33 ` zhengbin (A)
2019-10-08 14:24 ` Kalle Valo [this message]
2019-10-09 0:17 ` zhengbin (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0f771s7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).