From: Ajay Singh <ajay.kathat@microchip.com>
To: Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>
Cc: <kvalo@codeaurora.org>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <aditya.shankar@microchip.com>,
<venkateswara.kaja@microchip.com>, <claudiu.beznea@microchip.com>,
<adham.abozaeid@microchip.com>
Subject: Re: [PATCH 03/19] wilc: add host_interface.h
Date: Tue, 9 Oct 2018 17:48:32 +0530 [thread overview]
Message-ID: <092b38f4-8153-9abd-890a-a42454f22154@microchip.com> (raw)
In-Reply-To: <1539085569.3687.115.camel@sipsolutions.net>
On 10/9/2018 5:16 PM, Johannes Berg wrote:
> On Tue, 2018-10-09 at 17:14 +0530, Ajay Singh wrote:
>> On 10/9/2018 4:06 PM, Johannes Berg wrote:
>>> On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote:
>>>
>>>>>> +typedef void (*wilc_remain_on_chan_expired)(void *, u32);
>>>>>> +typedef void (*wilc_remain_on_chan_ready)(void *);
>>>> I think as per coding style the typedef for function pointer are allowed.
>>> True, I guess, but why do you need them?
>> Actually these function pointer are used in multiple places i.e inside
>> the struct and also for passing as the argument for the function. So i
>> think its better to keep them as typedef to simplify and avoid any 'line
>> over 80 chars' checkpatch issue. But anyway if you suggest we can modify
>> to remove these typedefs .
> I guess that must be part of the internal bounce buffer mechanism? I
> guess leave them for now and see what falls out.
>
>>>>>> +struct hidden_network {
>>>>>>
>> Yes, its not related to hidden SSID. Suppose cfg80211 scan is called
>> with SSID information(active scan) then SSID info will be maintained in
>> this structure.
> so maybe rename this?
>
Yes, sure I will rename this struct.
Regards,
Ajay
next prev parent reply other threads:[~2018-10-09 12:18 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 10:25 [RFC 00/19] wilc: added driver for wilc module Ajay Singh
2018-09-26 10:25 ` [PATCH 01/19] wilc: add coreconfigurator.h Ajay Singh
2018-09-26 10:25 ` [PATCH 02/19] wilc: add coreconfigurator.c Ajay Singh
2018-10-08 14:16 ` Johannes Berg
2018-10-09 9:42 ` Ajay Singh
2018-10-09 10:05 ` Johannes Berg
2018-09-26 10:25 ` [PATCH 03/19] wilc: add host_interface.h Ajay Singh
2018-10-08 14:20 ` Johannes Berg
2018-10-09 10:34 ` Ajay Singh
2018-10-09 10:36 ` Johannes Berg
2018-10-09 11:44 ` Ajay Singh
2018-10-09 11:46 ` Johannes Berg
2018-10-09 12:18 ` Ajay Singh [this message]
2018-10-09 18:36 ` Adham.Abozaeid
2018-10-09 19:14 ` Johannes Berg
2018-10-09 20:01 ` Adham.Abozaeid
2018-10-09 20:02 ` Johannes Berg
2018-10-09 20:06 ` Adham.Abozaeid
2018-10-29 14:56 ` Kalle Valo
2018-10-30 3:20 ` Ajay.Kathat
2018-09-26 10:25 ` [PATCH 04/19] wilc: add host_interface.c Ajay Singh
2018-10-08 14:31 ` Johannes Berg
2018-10-10 20:06 ` Adham.Abozaeid
2018-10-11 7:01 ` Johannes Berg
2018-10-12 22:08 ` Adham.Abozaeid
2018-10-18 8:23 ` Johannes Berg
2018-10-18 18:30 ` Adham.Abozaeid
2018-10-19 7:02 ` Johannes Berg
2018-10-19 20:53 ` Adham.Abozaeid
2018-10-29 20:10 ` Johannes Berg
2018-10-29 21:32 ` Adham.Abozaeid
2018-10-29 21:33 ` Johannes Berg
2018-10-11 6:57 ` Ajay Singh
2018-10-10 20:14 ` Johannes Berg
2018-10-12 21:55 ` Adham.Abozaeid
2018-10-18 8:23 ` Johannes Berg
2018-09-26 10:25 ` [PATCH 05/19] wilc: add wilc_wlan_if.h Ajay Singh
2018-10-08 14:33 ` Johannes Berg
2018-10-11 6:59 ` Ajay Singh
2018-09-26 10:25 ` [PATCH 06/19] wilc: add wilc_wlan_cfg.h Ajay Singh
2018-09-26 10:25 ` [PATCH 07/19] wilc: add wilc_wlan_cfg.c Ajay Singh
2018-09-26 10:25 ` [PATCH 08/19] wilc: add wilc_wlan.h Ajay Singh
2018-09-26 10:25 ` [PATCH 09/19] wilc: add wilc_wlan.c Ajay Singh
2018-09-26 10:25 ` [PATCH 10/19] wilc: add wilc_wfi_netdevice.h Ajay Singh
2018-09-26 10:25 ` [PATCH 11/19] wilc: add wilc_wfi_cfgoperations.h Ajay Singh
2018-09-26 10:25 ` [PATCH 12/19] wilc: add wilc_wfi_cfgoperations.c Ajay Singh
2018-10-08 14:57 ` Johannes Berg
2018-10-09 4:23 ` Adham.Abozaeid
2018-10-09 7:55 ` Johannes Berg
2018-10-09 17:15 ` Adham.Abozaeid
2018-10-19 21:47 ` Adham.Abozaeid
2018-10-29 20:11 ` Johannes Berg
2018-10-29 21:43 ` Adham.Abozaeid
2018-09-26 10:25 ` [PATCH 13/19] wilc: add linux_wlan.c Ajay Singh
2018-10-08 14:41 ` Johannes Berg
2018-10-11 7:00 ` Ajay Singh
2018-10-11 7:03 ` Johannes Berg
2018-10-11 7:26 ` Ajay Singh
2018-09-26 10:25 ` [PATCH 14/19] wilc: add linux_mon.c Ajay Singh
2018-10-08 14:44 ` Johannes Berg
2018-10-11 7:12 ` Ajay Singh
2018-10-11 7:15 ` Johannes Berg
2018-09-26 10:25 ` [PATCH 15/19] wilc: add wilc_spi.c Ajay Singh
2018-09-26 10:25 ` [PATCH 16/19] wilc: add wilc_sdio.c Ajay Singh
2018-09-26 10:25 ` [PATCH 17/19] wilc: updated DT device binding for wilc device Ajay Singh
2018-09-26 10:25 ` [PATCH 18/19] wilc: add Makefile and Kconfig files for wilc compilation Ajay Singh
2018-09-26 10:25 ` [PATCH 19/19] wilc: added wilc module compilation in wireless Makefile & Kconfig Ajay Singh
2018-10-06 12:45 ` [RFC 00/19] wilc: added driver for wilc module Kalle Valo
2018-10-08 5:17 ` Ajay Singh
2018-10-08 7:38 ` Kalle Valo
2018-10-08 18:34 ` Adham.Abozaeid
2018-11-15 14:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=092b38f4-8153-9abd-890a-a42454f22154@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).