From: Johannes Berg <johannes@sipsolutions.net>
To: Kan Yan <kyan@google.com>
Cc: linux-wireless@vger.kernel.org,
make-wifi-fast@lists.bufferbloat.net, toke@redhat.com,
nbd@nbd.name, yiboz@codeaurora.org
Subject: Re: [PATCH 1/2] mac80211: Implement Airtime-based Queue Limit (AQL)
Date: Fri, 04 Oct 2019 14:34:41 +0200 [thread overview]
Message-ID: <0dbf438d7e176c85164b8568a98f0d6e98292152.camel@sipsolutions.net> (raw)
In-Reply-To: <20191004062151.131405-2-kyan@google.com> (sfid-20191004_082219_852781_215A08B7)
On Thu, 2019-10-03 at 23:21 -0700, Kan Yan wrote:
>
> +/* The firmware's transmit queue size limit in airtime */
> +#define IEEE80211_DEFAULT_AQL_INTERFACE_LIMIT 24000
I'm not sure I understand this completely, but IMHO rewording it to be
like a "NIC limit" would be better.
However, I'm not sure it *shouldn't* actually be per interface (i.e.
moving from
local->aql_total_pending_airtime
to
sdata->aql_total_pending_airtime
because you could have multiple channels etc. involved and then using a
single airtime limit across two interfaces that are actually on two
different channels (e.g. 2.4 and 5 GHz) doesn't make that much sense.
Actually, it does make some sense as long as the NIC is actually
channel-hopping ... but that's in the process of changing now, there's
going to be hardware really soon (or perhaps already exists) that has
real dual-band capabilities...
Maybe we can live with this now, but we'd probably expect to change this
really soon.
johannes
next prev parent reply other threads:[~2019-10-04 12:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 6:21 [PATCH 0/2] Implement Airtime-based Queue Limit (AQL) Kan Yan
2019-10-04 6:21 ` [PATCH 1/2] mac80211: " Kan Yan
2019-10-04 12:30 ` Johannes Berg
2019-10-04 12:34 ` Johannes Berg [this message]
2019-10-04 15:44 ` Toke Høiland-Jørgensen
2019-10-05 2:08 ` Kan Yan
2019-10-05 2:19 ` Kan Yan
2019-10-06 17:40 ` Toke Høiland-Jørgensen
2019-10-07 19:23 ` Johannes Berg
2019-10-07 19:32 ` [Make-wifi-fast] " Dave Taht
2019-10-07 19:40 ` Toke Høiland-Jørgensen
2019-10-07 19:43 ` Johannes Berg
2019-10-10 2:35 ` Kan Yan
2019-10-04 6:21 ` [PATCH 2/2] ath10k: Enable " Kan Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbf438d7e176c85164b8568a98f0d6e98292152.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=toke@redhat.com \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).