* [PATCH 2.6.31] ath5k: temporarily disable crypto for AP mode
@ 2009-07-14 1:57 Bob Copeland
2009-08-25 20:30 ` Pavel Roskin
0 siblings, 1 reply; 3+ messages in thread
From: Bob Copeland @ 2009-07-14 1:57 UTC (permalink / raw)
To: linville; +Cc: proski, ath5k-devel, linux-wireless
Pavel Roskin reported some issues with using AP mode without
nohwcrypt=1. Most likely this is similar to the problem fixed
some time ago in ath9k by 3f53dd64f192450cb331c0fecfc26ca952fb242f,
"ath9k: Fix hw crypto configuration for TKIP in AP mode."
That only affects TKIP but it's easiest to just disable that and
WEP too until we get a proper fix in.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
Pavel, this ok with you for now?
drivers/net/wireless/ath/ath5k/base.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 20ba6fa..7db32ce 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2980,6 +2980,9 @@ ath5k_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
if (modparam_nohwcrypt)
return -EOPNOTSUPP;
+ if (sc->opmode == NL80211_IFTYPE_AP)
+ return -EOPNOTSUPP;
+
switch (key->alg) {
case ALG_WEP:
case ALG_TKIP:
--
1.6.2.5
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.31] ath5k: temporarily disable crypto for AP mode
2009-07-14 1:57 [PATCH 2.6.31] ath5k: temporarily disable crypto for AP mode Bob Copeland
@ 2009-08-25 20:30 ` Pavel Roskin
2009-08-25 20:58 ` Bob Copeland
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Roskin @ 2009-08-25 20:30 UTC (permalink / raw)
To: Bob Copeland; +Cc: linville, ath5k-devel, linux-wireless
On Mon, 2009-07-13 at 21:57 -0400, Bob Copeland wrote:
> Pavel Roskin reported some issues with using AP mode without
> nohwcrypt=1. Most likely this is similar to the problem fixed
> some time ago in ath9k by 3f53dd64f192450cb331c0fecfc26ca952fb242f,
> "ath9k: Fix hw crypto configuration for TKIP in AP mode."
>
> That only affects TKIP but it's easiest to just disable that and
> WEP too until we get a proper fix in.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
>
> Pavel, this ok with you for now?
Sorry for delay. I don't have time to test it, but I have no specific
objections.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.31] ath5k: temporarily disable crypto for AP mode
2009-08-25 20:30 ` Pavel Roskin
@ 2009-08-25 20:58 ` Bob Copeland
0 siblings, 0 replies; 3+ messages in thread
From: Bob Copeland @ 2009-08-25 20:58 UTC (permalink / raw)
To: Pavel Roskin; +Cc: linville, ath5k-devel, linux-wireless
On Tue, Aug 25, 2009 at 4:30 PM, Pavel Roskin<proski@gnu.org> wrote:
>>
>> Pavel, this ok with you for now?
>
> Sorry for delay. I don't have time to test it, but I have no specific
> objections.
Thanks, for the update. It already went to Linus I believe.
I did spend enough time looking at the root problem to decide that
fixing it won't be too hard, but I also saw some questionable logic
in the original code that wants a cleanup, I can post patches soon.
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-25 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-14 1:57 [PATCH 2.6.31] ath5k: temporarily disable crypto for AP mode Bob Copeland
2009-08-25 20:30 ` Pavel Roskin
2009-08-25 20:58 ` Bob Copeland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).