[RFC PATCH 1/1] mac80211: Disable cfg80211 assoc timeout warning

[RFC PATCH 1/1] mac80211: Disable cfg80211 assoc timeout warning

[Saravanan Dhanabal]

While the association response is queued and yet to be
processed, if the interface goes down, ieee80211_stop
marks work queue items as IEEE80211_WORK_ABORT. This
creates assoc timeout warnings which are actually caused
by if down. Those warnings could be avoided, since they
are not beacuse of association response.

This patch disables assoc timeout warnings if interface is
not running.

Signed-off-by: Saravanan Dhanabal <ext-saravanan.dhanabal@nokia.com>
---
 net/wireless/mlme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
index 0855f0d..a3ab86c 100644
--- a/net/wireless/mlme.c
+++ b/net/wireless/mlme.c
@@ -337,7 +337,7 @@ void cfg80211_send_assoc_timeout(struct net_device *dev, const u8 *addr)
 		}
 	}
 
-	WARN_ON(!done);
+	WARN_ON(netif_running(dev) && !done);
 
 	wdev_unlock(wdev);
 }
-- 
1.7.0

Re: [RFC PATCH 1/1] mac80211: Disable cfg80211 assoc timeout warning

[Johannes Berg]

On Mon, 2010-04-26 at 12:49 +0300, Saravanan Dhanabal wrote:
> While the association response is queued and yet to be
> processed, if the interface goes down, ieee80211_stop
> marks work queue items as IEEE80211_WORK_ABORT. This
> creates assoc timeout warnings which are actually caused
> by if down. Those warnings could be avoided, since they
> are not beacuse of association response.
> 
> This patch disables assoc timeout warnings if interface is
> not running.

I don't think this is the right fix, we just debated exactly this
problem too.

The right fix would be to make mac80211 kill the association work when
deauthentication is requested. We're testing that fix right now.

johannes

> Signed-off-by: Saravanan Dhanabal <ext-saravanan.dhanabal@nokia.com>
> ---
>  net/wireless/mlme.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
> index 0855f0d..a3ab86c 100644
> --- a/net/wireless/mlme.c
> +++ b/net/wireless/mlme.c
> @@ -337,7 +337,7 @@ void cfg80211_send_assoc_timeout(struct net_device *dev, const u8 *addr)
>  		}
>  	}
>  
> -	WARN_ON(!done);
> +	WARN_ON(netif_running(dev) && !done);
>  
>  	wdev_unlock(wdev);
>  }

RE: [RFC PATCH 1/1] mac80211: Disable cfg80211 assoc timeout warning

[ext-saravanan.dhanabal]

OK. Please let me know about that fix after testing, so that I could follow it up.

-saravanan d.
________________________________________
From: ext Johannes Berg [johannes@sipsolutions.net]
Sent: Monday, April 26, 2010 12:53 PM
To: Dhanabal Saravanan (EXT-Sasken/Tampere)
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] mac80211: Disable cfg80211 assoc timeout warning

On Mon, 2010-04-26 at 12:49 +0300, Saravanan Dhanabal wrote:
> While the association response is queued and yet to be
> processed, if the interface goes down, ieee80211_stop
> marks work queue items as IEEE80211_WORK_ABORT. This
> creates assoc timeout warnings which are actually caused
> by if down. Those warnings could be avoided, since they
> are not beacuse of association response.
>
> This patch disables assoc timeout warnings if interface is
> not running.

I don't think this is the right fix, we just debated exactly this
problem too.

The right fix would be to make mac80211 kill the association work when
deauthentication is requested. We're testing that fix right now.

johannes

> Signed-off-by: Saravanan Dhanabal <ext-saravanan.dhanabal@nokia.com>
> ---
>  net/wireless/mlme.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
> index 0855f0d..a3ab86c 100644
> --- a/net/wireless/mlme.c
> +++ b/net/wireless/mlme.c
> @@ -337,7 +337,7 @@ void cfg80211_send_assoc_timeout(struct net_device *dev, const u8 *addr)
>               }
>       }
>
> -     WARN_ON(!done);
> +     WARN_ON(netif_running(dev) && !done);
>
>       wdev_unlock(wdev);
>  }

RE: [RFC PATCH 1/1] mac80211: Disable cfg80211 assoc timeout warning

[Johannes Berg]

On Wed, 2010-04-28 at 15:12 +0200, ext-saravanan.dhanabal@nokia.com
wrote:
> OK. Please let me know about that fix after testing, so that I could follow it up.

This is tracked here: https://bugzilla.kernel.org/show_bug.cgi?id=15794

johannes