* [patch -next] libertas: precedence bug
@ 2010-07-22 12:21 Dan Carpenter
2010-07-22 22:24 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-07-22 12:21 UTC (permalink / raw)
To: Dan Williams
Cc: John W. Linville, Holger Schurig, David S. Miller,
Amitkumar Karwar, Stephen Hemminger, libertas-dev,
linux-wireless, kernel-janitors
Negate has precedence over comparison so the original test was always
false. (Neither 0 nor 1 are equal to NL80211_IFTYPE_MONITOR).
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/libertas/tx.c b/drivers/net/wireless/libertas/tx.c
index 411a3bb..8000ca6 100644
--- a/drivers/net/wireless/libertas/tx.c
+++ b/drivers/net/wireless/libertas/tx.c
@@ -180,7 +180,7 @@ void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
{
struct tx_radiotap_hdr *radiotap_hdr;
- if (!priv->wdev->iftype == NL80211_IFTYPE_MONITOR ||
+ if (priv->wdev->iftype != NL80211_IFTYPE_MONITOR ||
priv->currenttxskb == NULL)
return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next] libertas: precedence bug
2010-07-22 12:21 [patch -next] libertas: precedence bug Dan Carpenter
@ 2010-07-22 22:24 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2010-07-22 22:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: John W. Linville, Holger Schurig, David S. Miller,
Amitkumar Karwar, Stephen Hemminger, libertas-dev,
linux-wireless, kernel-janitors
On Thu, 2010-07-22 at 14:21 +0200, Dan Carpenter wrote:
> Negate has precedence over comparison so the original test was always
> false. (Neither 0 nor 1 are equal to NL80211_IFTYPE_MONITOR).
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> diff --git a/drivers/net/wireless/libertas/tx.c b/drivers/net/wireless/libertas/tx.c
> index 411a3bb..8000ca6 100644
> --- a/drivers/net/wireless/libertas/tx.c
> +++ b/drivers/net/wireless/libertas/tx.c
> @@ -180,7 +180,7 @@ void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
> {
> struct tx_radiotap_hdr *radiotap_hdr;
>
> - if (!priv->wdev->iftype == NL80211_IFTYPE_MONITOR ||
> + if (priv->wdev->iftype != NL80211_IFTYPE_MONITOR ||
> priv->currenttxskb == NULL)
> return;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-22 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-22 12:21 [patch -next] libertas: precedence bug Dan Carpenter
2010-07-22 22:24 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).