* [PATCH] mac80211: inform drivers about the off-channel status on channel changes
@ 2010-07-28 0:40 Felix Fietkau
2010-07-28 6:50 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2010-07-28 0:40 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville, Johannes Berg
For some drivers it can be useful to know whether the channel they're
supposed to switch to is going to be used for short off-channel work or
scanning, or whether the hardware is expected to stay on it for a while
longer. This is important for various kinds of calibration work, which
takes longer to complete and should keep some persistent state, even if
the channel temporarily changes.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
I need something like this for properly getting rid of the ath9k sw
scanning callback and for fixing various calibration bugs.
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -625,11 +625,14 @@ struct ieee80211_rx_status {
* may turn the device off as much as possible. Typically, this flag will
* be set when an interface is set UP but not associated or scanning, but
* it can also be unset in that case when monitor interfaces are active.
+ * @IEEE80211_CONF_OFFCHANNEL: The device is currently not on its main
+ * operating channel.
*/
enum ieee80211_conf_flags {
IEEE80211_CONF_MONITOR = (1<<0),
IEEE80211_CONF_PS = (1<<1),
IEEE80211_CONF_IDLE = (1<<2),
+ IEEE80211_CONF_OFFCHANNEL = (1<<3),
};
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -111,12 +111,15 @@ int ieee80211_hw_config(struct ieee80211
if (scan_chan) {
chan = scan_chan;
channel_type = NL80211_CHAN_NO_HT;
+ local->hw.conf.flags |= IEEE80211_CONF_OFFCHANNEL;
} else if (local->tmp_channel) {
chan = scan_chan = local->tmp_channel;
channel_type = local->tmp_channel_type;
+ local->hw.conf.flags |= IEEE80211_CONF_OFFCHANNEL;
} else {
chan = local->oper_channel;
channel_type = local->_oper_channel_type;
+ local->hw.conf.flags &= ~IEEE80211_CONF_OFFCHANNEL;
}
if (chan != local->hw.conf.channel ||
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: inform drivers about the off-channel status on channel changes
2010-07-28 0:40 [PATCH] mac80211: inform drivers about the off-channel status on channel changes Felix Fietkau
@ 2010-07-28 6:50 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2010-07-28 6:50 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, John W. Linville
On Wed, 2010-07-28 at 02:40 +0200, Felix Fietkau wrote:
> For some drivers it can be useful to know whether the channel they're
> supposed to switch to is going to be used for short off-channel work or
> scanning, or whether the hardware is expected to stay on it for a while
> longer. This is important for various kinds of calibration work, which
> takes longer to complete and should keep some persistent state, even if
> the channel temporarily changes.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> I need something like this for properly getting rid of the ath9k sw
> scanning callback and for fixing various calibration bugs.
Fine with me, I'll just have to hope people don't abuse it too
much... :-)
johannes
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -625,11 +625,14 @@ struct ieee80211_rx_status {
> * may turn the device off as much as possible. Typically, this flag will
> * be set when an interface is set UP but not associated or scanning, but
> * it can also be unset in that case when monitor interfaces are active.
> + * @IEEE80211_CONF_OFFCHANNEL: The device is currently not on its main
> + * operating channel.
> */
> enum ieee80211_conf_flags {
> IEEE80211_CONF_MONITOR = (1<<0),
> IEEE80211_CONF_PS = (1<<1),
> IEEE80211_CONF_IDLE = (1<<2),
> + IEEE80211_CONF_OFFCHANNEL = (1<<3),
> };
>
>
> --- a/net/mac80211/main.c
> +++ b/net/mac80211/main.c
> @@ -111,12 +111,15 @@ int ieee80211_hw_config(struct ieee80211
> if (scan_chan) {
> chan = scan_chan;
> channel_type = NL80211_CHAN_NO_HT;
> + local->hw.conf.flags |= IEEE80211_CONF_OFFCHANNEL;
> } else if (local->tmp_channel) {
> chan = scan_chan = local->tmp_channel;
> channel_type = local->tmp_channel_type;
> + local->hw.conf.flags |= IEEE80211_CONF_OFFCHANNEL;
> } else {
> chan = local->oper_channel;
> channel_type = local->_oper_channel_type;
> + local->hw.conf.flags &= ~IEEE80211_CONF_OFFCHANNEL;
> }
>
> if (chan != local->hw.conf.channel ||
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-28 6:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-28 0:40 [PATCH] mac80211: inform drivers about the off-channel status on channel changes Felix Fietkau
2010-07-28 6:50 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).