linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: support use of NAPI for bottom-half processing
Date: Thu, 29 Jul 2010 22:42:06 +0200	[thread overview]
Message-ID: <1280436126.3823.22.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1280435978.3823.20.camel@jlt3.sipsolutions.net>

On Thu, 2010-07-29 at 22:39 +0200, Johannes Berg wrote:

> > +	int (*napi_poll)(struct napi_struct *napi, int budget);
> 
> I'd prefer passing the hw here and having mac80211 wrap it in a simple
> function that does the container_of magic? Anything preventing that?
> Then the napi struct can be hidden from drivers.

Ok actually that requires wrapping napi_complete() too, that doesn't
seem worth it. Can you wrap the container_of() in an inline though and
maybe do "struct napi_struct _napi;" and document it shouldn't really be
touched or something?

johannes


  reply	other threads:[~2010-07-29 20:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 20:14 [PATCH 1/2] mac80211: support use of NAPI for bottom-half processing John W. Linville
2010-07-29 20:14 ` [PATCH 2/2] rtl8180: use " John W. Linville
2010-07-29 20:39 ` [PATCH 1/2] mac80211: support use of " Johannes Berg
2010-07-29 20:42   ` Johannes Berg [this message]
2010-07-29 21:14   ` [PATCH v2 " John W. Linville
2010-07-29 21:14   ` [PATCH v2 2/2] rtl8180: use " John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280436126.3823.22.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).