From: Joe Perches <joe@perches.com>
To: Kshitij Kulshreshtha <kkhere.geo@gmail.com>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] compat: define struct va_format introduced in v2.6.36
Date: Mon, 02 Aug 2010 13:08:47 -0700 [thread overview]
Message-ID: <1280779727.1752.71.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4C57227A.1050802@gmail.com>
On Mon, 2010-08-02 at 21:54 +0200, Kshitij Kulshreshtha wrote:
> As on 2010-08-02 21:48, Joe Perches did write:
> > On Mon, 2010-08-02 at 21:39 +0200, Kshitij Kulshreshtha wrote:
> >> As on 2010-08-02 20:00, Luis R. Rodriguez did write:
> >>> On Sun, Aug 1, 2010 at 3:02 PM, Kshitij Kulshreshtha
> >>>> +struct va_format {
> >>>> + const char *fmt;
> >>>> + va_list *va;
> >>>> +};
> >>> I'll apply this for now but what caller uses this for example?
> > Why is this necessary?
> I needed this to compile compat-wireless which is based on linux-next.
> Otherwise net/wireless/core.c fails to compile, due to the use of this
> struct va_format in the functions defined in lines 910--958. If this
> usage is reverted, we won't need it in compat.
I see your problem.
I think your problem should not be a constraint
on new development and I do not think the new use
should be reverted.
cheers, Joe
next prev parent reply other threads:[~2010-08-02 20:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 13:40 compat-wireless-2010-07-28.tar.bz2 fails to compile with 2.6.34.1 Kshitij Kulshreshtha
2010-08-01 19:59 ` Hauke Mehrtens
2010-08-01 22:02 ` [PATCH] build fixes for compat.git and compat-wireless.git Kshitij Kulshreshtha
2010-08-01 22:02 ` [PATCH 1/3] compat: backport hex_to_bin first introduced in v2.6.35 Kshitij Kulshreshtha
2010-08-01 22:02 ` [PATCH 2/3] compat: header <pcmcia/cs_types.h> was removed in v2.6.36 Kshitij Kulshreshtha
2010-08-01 22:02 ` [PATCH 3/3] compat: define struct va_format introduced " Kshitij Kulshreshtha
2010-08-02 18:00 ` Luis R. Rodriguez
2010-08-02 19:39 ` Kshitij Kulshreshtha
2010-08-02 19:48 ` Joe Perches
2010-08-02 19:54 ` Kshitij Kulshreshtha
2010-08-02 20:08 ` Joe Perches [this message]
2010-08-02 20:42 ` Luis R. Rodriguez
2010-08-01 22:02 ` [PATCH 4/5] compat-wireless: allow compilation of compat-2.6.35.c from compat Kshitij Kulshreshtha
2010-08-01 22:02 ` [PATCH 5/5] compat-wireless: copy headers in include/pcmcia " Kshitij Kulshreshtha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280779727.1752.71.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=hauke@hauke-m.de \
--cc=kkhere.geo@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).