* [PATCH 0/3] Fix incorrect returned signal strengths
@ 2013-11-05 21:15 Larry Finger
2013-11-05 21:15 ` [PATCH 1/3] rtlwifi: rtl8192se: Fix incorrect signal strength for unassociated AP Larry Finger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Larry Finger @ 2013-11-05 21:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry Finger, netdev
In rtl8192se, rtl8192cu, and rtl8192du, the routines that process the
received frames get the signal strength from the RSSI value. Unfortunately,
that value is non-zero only if the interface is associated with the AP. As
a result, scans return incorrect values for the strength, which causes
unwanted attempts to roam.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Larry Finger (3):
rtlwifi: rtl8192se: Fix incorrect signal strength for unassociated AP
rtlwifi: rtl8192cu: Fix incorrect signal strength for unassociated AP
rtlwifi: rtl8192de: Fix incorrect signal strength for unassociated AP
drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
1.8.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] rtlwifi: rtl8192se: Fix incorrect signal strength for unassociated AP
2013-11-05 21:15 [PATCH 0/3] Fix incorrect returned signal strengths Larry Finger
@ 2013-11-05 21:15 ` Larry Finger
2013-11-05 21:15 ` [PATCH 2/3] rtlwifi: rtl8192cu: " Larry Finger
2013-11-05 21:15 ` [PATCH 3/3] rtlwifi: rtl8192de: " Larry Finger
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2013-11-05 21:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry Finger, netdev, Stable
The routine that processes received frames was returning the RSSI value for the
signal strength; however, that value is available only for associated APs. As
a result, the strength was the absurd value of 10 dBm. As a result, scans
return incorrect values for the strength, which causes unwanted attempts to roam.
This patch fixes https://bugzilla.kernel.org/show_bug.cgi?id=63881.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-by: Matthieu Baerts <matttbe@gmail.com>
Cc: Stable <stable@vger.kernel.org> [3.0 +]
---
drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
index 222d2e7..27efbcd 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
@@ -329,7 +329,7 @@ bool rtl92se_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats,
}
/*rx_status->qual = stats->signal; */
- rx_status->signal = stats->rssi + 10;
+ rx_status->signal = stats->recvsignalpower + 10;
return true;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] rtlwifi: rtl8192cu: Fix incorrect signal strength for unassociated AP
2013-11-05 21:15 [PATCH 0/3] Fix incorrect returned signal strengths Larry Finger
2013-11-05 21:15 ` [PATCH 1/3] rtlwifi: rtl8192se: Fix incorrect signal strength for unassociated AP Larry Finger
@ 2013-11-05 21:15 ` Larry Finger
2013-11-05 21:15 ` [PATCH 3/3] rtlwifi: rtl8192de: " Larry Finger
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2013-11-05 21:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry Finger, netdev, Stable
The routine that processes received frames was returning the RSSI value for the
signal strength; however, that value is available only for associated APs. As
a result, the strength was the absurd value of 10 dBm. As a result, scans
return incorrect values for the strength, which causes unwanted attempts to roam.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org> [2.6.39+]
---
drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
index 25e50ff..b0c346a 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
@@ -349,7 +349,7 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw,
p_drvinfo);
}
/*rx_status->qual = stats->signal; */
- rx_status->signal = stats->rssi + 10;
+ rx_status->signal = stats->recvsignalpower + 10;
return true;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] rtlwifi: rtl8192de: Fix incorrect signal strength for unassociated AP
2013-11-05 21:15 [PATCH 0/3] Fix incorrect returned signal strengths Larry Finger
2013-11-05 21:15 ` [PATCH 1/3] rtlwifi: rtl8192se: Fix incorrect signal strength for unassociated AP Larry Finger
2013-11-05 21:15 ` [PATCH 2/3] rtlwifi: rtl8192cu: " Larry Finger
@ 2013-11-05 21:15 ` Larry Finger
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2013-11-05 21:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry Finger, netdev, Stable
The routine that processes received frames was returning the RSSI value for the
signal strength; however, that value is available only for associated APs. As
a result, the strength was the absurd value of 10 dBm. As a result, scans
return incorrect values for the strength, which causes unwanted attempts to roam.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org> [3.1+]
---
drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c
index 945ddec..0eb0f4a 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c
@@ -525,7 +525,7 @@ bool rtl92de_rx_query_desc(struct ieee80211_hw *hw, struct rtl_stats *stats,
p_drvinfo);
}
/*rx_status->qual = stats->signal; */
- rx_status->signal = stats->rssi + 10;
+ rx_status->signal = stats->recvsignalpower + 10;
return true;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-05 21:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-05 21:15 [PATCH 0/3] Fix incorrect returned signal strengths Larry Finger
2013-11-05 21:15 ` [PATCH 1/3] rtlwifi: rtl8192se: Fix incorrect signal strength for unassociated AP Larry Finger
2013-11-05 21:15 ` [PATCH 2/3] rtlwifi: rtl8192cu: " Larry Finger
2013-11-05 21:15 ` [PATCH 3/3] rtlwifi: rtl8192de: " Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).