* [PATCH] ath5k: document a fall-through case in ath5k_hw_set_opmode
@ 2015-01-19 19:09 John W. Linville
2015-01-23 16:59 ` Nick Kossifidis
2015-01-23 19:18 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: John W. Linville @ 2015-01-19 19:09 UTC (permalink / raw)
To: linux-wireless
Cc: Kalle Valo, Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez,
ath5k-devel, John W. Linville
Coverity: CID 114932
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
I'm guessing this is OK, since it seems to work?
drivers/net/wireless/ath/ath5k/pcu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index c60d36aa13e2..bf29da5e90da 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -912,6 +912,7 @@ ath5k_hw_set_opmode(struct ath5k_hw *ah, enum nl80211_iftype op_mode)
pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
| (ah->ah_version == AR5K_AR5210 ?
AR5K_STA_ID1_PWR_SV : 0);
+ /* fall through */
case NL80211_IFTYPE_MONITOR:
pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
| (ah->ah_version == AR5K_AR5210 ?
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath5k: document a fall-through case in ath5k_hw_set_opmode
2015-01-19 19:09 [PATCH] ath5k: document a fall-through case in ath5k_hw_set_opmode John W. Linville
@ 2015-01-23 16:59 ` Nick Kossifidis
2015-01-23 19:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Nick Kossifidis @ 2015-01-23 16:59 UTC (permalink / raw)
To: John W. Linville
Cc: linux-wireless, Kalle Valo, Jiri Slaby, Luis R. Rodriguez, ath5k-devel
It's AR5210 related, we haven't worked much on that chip but I think that's ok.
AR5K_STA_ID1_NO_PSPOLL is set in every case on AR5210 so this
fall-through makes sure it gets set on station and monitor mode too.
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
2015-01-19 21:09 GMT+02:00 John W. Linville <linville@tuxdriver.com>:
> Coverity: CID 114932
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> I'm guessing this is OK, since it seems to work?
>
> drivers/net/wireless/ath/ath5k/pcu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
> index c60d36aa13e2..bf29da5e90da 100644
> --- a/drivers/net/wireless/ath/ath5k/pcu.c
> +++ b/drivers/net/wireless/ath/ath5k/pcu.c
> @@ -912,6 +912,7 @@ ath5k_hw_set_opmode(struct ath5k_hw *ah, enum nl80211_iftype op_mode)
> pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
> | (ah->ah_version == AR5K_AR5210 ?
> AR5K_STA_ID1_PWR_SV : 0);
> + /* fall through */
> case NL80211_IFTYPE_MONITOR:
> pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
> | (ah->ah_version == AR5K_AR5210 ?
> --
> 2.1.0
>
--
GPG ID: 0xEE878588
As you read this post global entropy rises. Have Fun ;-)
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath5k: document a fall-through case in ath5k_hw_set_opmode
2015-01-19 19:09 [PATCH] ath5k: document a fall-through case in ath5k_hw_set_opmode John W. Linville
2015-01-23 16:59 ` Nick Kossifidis
@ 2015-01-23 19:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2015-01-23 19:18 UTC (permalink / raw)
To: John Linville
Cc: linux-wireless, Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez,
ath5k-devel, John W. Linville
> Coverity: CID 114932
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-23 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-19 19:09 [PATCH] ath5k: document a fall-through case in ath5k_hw_set_opmode John W. Linville
2015-01-23 16:59 ` Nick Kossifidis
2015-01-23 19:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).