* [PATCH] net:wireless - Change 1 to true for bool type variable.
@ 2015-05-25 17:55 Shailendra Verma
2015-05-25 18:06 ` Larry Finger
2015-05-25 18:11 ` Joe Perches
0 siblings, 2 replies; 3+ messages in thread
From: Shailendra Verma @ 2015-05-25 17:55 UTC (permalink / raw)
To: Kalle Valo, linux-wireless, netdev; +Cc: linux-kernel, Shailendra Verma
The variable translate is bool type.So assigning true instead of 1.
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
drivers/net/wireless/ray_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 477f863..0881ba8 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -143,7 +143,7 @@ static int psm;
static char *essid;
/* Default to encapsulation unless translation requested */
-static bool translate = 1;
+static bool translate = true;
static int country = USA;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net:wireless - Change 1 to true for bool type variable.
2015-05-25 17:55 [PATCH] net:wireless - Change 1 to true for bool type variable Shailendra Verma
@ 2015-05-25 18:06 ` Larry Finger
2015-05-25 18:11 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2015-05-25 18:06 UTC (permalink / raw)
To: Shailendra Verma, Kalle Valo, linux-wireless, netdev; +Cc: linux-kernel
On 05/25/2015 12:55 PM, Shailendra Verma wrote:
> The variable translate is bool type.So assigning true instead of 1.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
When you submit a patch for a particular driver in the drivers/net/wireless/
tree, it is preferred that the subject start with the driver name, not with
net:wireless. Accordingly, your subject should be "ray_cs: Change 1 to true for
bool type variable". In fact, you can probably choose a better wording for the
rest of the title, but I do not insist.
Among other advantages, this choice of subject allows easy searches for patches
for a given driver using 'git log'.
Larry
> ---
> drivers/net/wireless/ray_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
> index 477f863..0881ba8 100644
> --- a/drivers/net/wireless/ray_cs.c
> +++ b/drivers/net/wireless/ray_cs.c
> @@ -143,7 +143,7 @@ static int psm;
> static char *essid;
>
> /* Default to encapsulation unless translation requested */
> -static bool translate = 1;
> +static bool translate = true;
>
> static int country = USA;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net:wireless - Change 1 to true for bool type variable.
2015-05-25 17:55 [PATCH] net:wireless - Change 1 to true for bool type variable Shailendra Verma
2015-05-25 18:06 ` Larry Finger
@ 2015-05-25 18:11 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2015-05-25 18:11 UTC (permalink / raw)
To: Shailendra Verma; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel
On Mon, 2015-05-25 at 23:25 +0530, Shailendra Verma wrote:
> The variable translate is bool type.So assigning true instead of 1.
There are a lot these in the kernel.
$ git grep -P "^[ \t]*(?:static[ \t]+)?(?:const\s+)?bool\s+\w+\s*=\s*[01]\s*;" * | wc -l
161
Are you going to submit patches for all of them one at a time?
I suggest sending maybe 10 to 12 patches, one for each subsystem,
and cc the trivial maintainer Jiri Kosina <trivial@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-25 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-25 17:55 [PATCH] net:wireless - Change 1 to true for bool type variable Shailendra Verma
2015-05-25 18:06 ` Larry Finger
2015-05-25 18:11 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).