From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Arik Nemtsov <arik@wizery.com>,
Arik Nemtsov <arikx.nemtsov@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: [PATCH 15/16] iwlwifi: mvm: disable TDLS ac queues correctly
Date: Sun, 25 Oct 2015 14:01:15 +0200 [thread overview]
Message-ID: <1445774476-24792-15-git-send-email-emmanuel.grumbach@intel.com> (raw)
In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB32E8AF6CC@hasmsx107.ger.corp.intel.com>
From: Arik Nemtsov <arik@wizery.com>
The iwl_mvm_disable_queue function requires the TID to be set to
IWL_MAX_TID_COUNT when disabling an AC queue. Call it correctly for TDLS
scenarios.
Fixes: 4ecafae9e568 ("iwlwifi: mvm: support using multiple ACs on single HW queue")
Signed-off-by: Arik Nemtsov <arikx.nemtsov@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/sta.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/sta.c b/drivers/net/wireless/iwlwifi/mvm/sta.c
index 04d0cb3..300a249 100644
--- a/drivers/net/wireless/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/iwlwifi/mvm/sta.c
@@ -255,7 +255,7 @@ static void iwl_mvm_tdls_sta_deinit(struct iwl_mvm *mvm,
/* disable the TDLS STA-specific queues */
sta_msk = mvmsta->tfd_queue_msk;
for_each_set_bit(i, &sta_msk, sizeof(sta_msk) * BITS_PER_BYTE)
- iwl_mvm_disable_txq(mvm, i, i, 0, 0);
+ iwl_mvm_disable_txq(mvm, i, i, IWL_MAX_TID_COUNT, 0);
}
int iwl_mvm_add_sta(struct iwl_mvm *mvm,
@@ -474,7 +474,8 @@ void iwl_mvm_sta_drained_wk(struct work_struct *wk)
unsigned long i, msk = mvm->tfd_drained[sta_id];
for_each_set_bit(i, &msk, sizeof(msk) * BITS_PER_BYTE)
- iwl_mvm_disable_txq(mvm, i, i, 0, 0);
+ iwl_mvm_disable_txq(mvm, i, i,
+ IWL_MAX_TID_COUNT, 0);
mvm->tfd_drained[sta_id] = 0;
IWL_DEBUG_TDLS(mvm, "Drained sta %d, with queues %ld\n",
--
2.1.4
next prev parent reply other threads:[~2015-10-25 12:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 11:58 pull request: iwlwifi-next 2015-10-25 Grumbach, Emmanuel
2015-10-25 12:01 ` [PATCH 01/16] iwlwifi: rs: Remove workaround that disables MIMO on P2P Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 02/16] iwlwifi: mvm: Dump FW's virtual image in the case of a NIC error Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 03/16] iwlwifi: pcie: fix (again) prepare card flow Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 04/16] iwlwifi: mvm: correctly request DTS-measure for new cards Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 05/16] iwlwifi: mvm: use wowlan RX/TX timeouts in D0i3 Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 06/16] iwlwifi: mvm: use short timeouts in P2P low latency if supported Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 07/16] iwlwifi: mvm: Allow setting ctrl-chnl-position in FTM responder Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 08/16] iwlwifi: mvm: let any command flag be passed to iwl_mvm_flushtx_path() Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 09/16] iwlwifi: mvm: Add support for two scheduled scan plans Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 10/16] iwlwifi: avoid read/write operations if the bus is dead Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 11/16] iwlwifi: mvm: Implement per vif frame registration API Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 12/16] iwlwifi: mvm: clean up some whitespace in scan code Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 13/16] iwlwifi: mvm: remove pointless scan plan checks Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 14/16] iwlwifi: mvm: take scan ref only on success Emmanuel Grumbach
2015-10-25 12:01 ` Emmanuel Grumbach [this message]
2015-10-25 12:01 ` [PATCH 16/16] iwlwifi: nvm: free old section data when reading nvm file Emmanuel Grumbach
2015-10-28 12:45 ` pull request: iwlwifi-next 2015-10-25 Kalle Valo
2015-10-28 14:03 ` Grumbach, Emmanuel
2015-10-28 18:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445774476-24792-15-git-send-email-emmanuel.grumbach@intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=arik@wizery.com \
--cc=arikx.nemtsov@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).