linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	<stable@vger.kernel.org>
Subject: [PATCH 03/16] iwlwifi: pcie: fix (again) prepare card flow
Date: Sun, 25 Oct 2015 14:01:03 +0200	[thread overview]
Message-ID: <1445774476-24792-3-git-send-email-emmanuel.grumbach@intel.com> (raw)
In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB32E8AF6CC@hasmsx107.ger.corp.intel.com>

The hardware bug in the commit mentioned below forces us
not to re-enable the clock gating in the Host Cluster.
The impact on the power consumption is minimal and it allows
the WAKE_ME interrupt to propagate.

CC: <stable@vger.kernel.org> [4.1+]
Fixes: c9fdec9f3970 ("iwlwifi: pcie: fix prepare card flow")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
 drivers/net/wireless/iwlwifi/pcie/trans.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/pcie/trans.c b/drivers/net/wireless/iwlwifi/pcie/trans.c
index 6ba7d30..9028345 100644
--- a/drivers/net/wireless/iwlwifi/pcie/trans.c
+++ b/drivers/net/wireless/iwlwifi/pcie/trans.c
@@ -592,10 +592,8 @@ static int iwl_pcie_prepare_card_hw(struct iwl_trans *trans)
 
 		do {
 			ret = iwl_pcie_set_hw_ready(trans);
-			if (ret >= 0) {
-				ret = 0;
-				goto out;
-			}
+			if (ret >= 0)
+				return 0;
 
 			usleep_range(200, 1000);
 			t += 200;
@@ -605,10 +603,6 @@ static int iwl_pcie_prepare_card_hw(struct iwl_trans *trans)
 
 	IWL_ERR(trans, "Couldn't prepare the card\n");
 
-out:
-	iwl_clear_bit(trans, CSR_DBG_LINK_PWR_MGMT_REG,
-		      CSR_RESET_LINK_PWR_MGMT_DISABLED);
-
 	return ret;
 }
 
-- 
2.1.4


  parent reply	other threads:[~2015-10-25 12:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 11:58 pull request: iwlwifi-next 2015-10-25 Grumbach, Emmanuel
2015-10-25 12:01 ` [PATCH 01/16] iwlwifi: rs: Remove workaround that disables MIMO on P2P Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 02/16] iwlwifi: mvm: Dump FW's virtual image in the case of a NIC error Emmanuel Grumbach
2015-10-25 12:01 ` Emmanuel Grumbach [this message]
2015-10-25 12:01 ` [PATCH 04/16] iwlwifi: mvm: correctly request DTS-measure for new cards Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 05/16] iwlwifi: mvm: use wowlan RX/TX timeouts in D0i3 Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 06/16] iwlwifi: mvm: use short timeouts in P2P low latency if supported Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 07/16] iwlwifi: mvm: Allow setting ctrl-chnl-position in FTM responder Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 08/16] iwlwifi: mvm: let any command flag be passed to iwl_mvm_flushtx_path() Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 09/16] iwlwifi: mvm: Add support for two scheduled scan plans Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 10/16] iwlwifi: avoid read/write operations if the bus is dead Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 11/16] iwlwifi: mvm: Implement per vif frame registration API Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 12/16] iwlwifi: mvm: clean up some whitespace in scan code Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 13/16] iwlwifi: mvm: remove pointless scan plan checks Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 14/16] iwlwifi: mvm: take scan ref only on success Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 15/16] iwlwifi: mvm: disable TDLS ac queues correctly Emmanuel Grumbach
2015-10-25 12:01 ` [PATCH 16/16] iwlwifi: nvm: free old section data when reading nvm file Emmanuel Grumbach
2015-10-28 12:45 ` pull request: iwlwifi-next 2015-10-25 Kalle Valo
2015-10-28 14:03   ` Grumbach, Emmanuel
2015-10-28 18:50 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445774476-24792-3-git-send-email-emmanuel.grumbach@intel.com \
    --to=emmanuel.grumbach@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).