From: Johannes Berg <johannes@sipsolutions.net>
To: nicolas.dichtel@6wind.com, David Ahern <dsa@cumulusnetworks.com>,
Jiri Pirko <jiri@resnulli.us>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Thu, 13 Apr 2017 15:29:30 +0200 [thread overview]
Message-ID: <1492090170.29526.1.camel@sipsolutions.net> (raw)
In-Reply-To: <c0b35e6e-e5cb-25f6-7ccf-eec33ba39f3b@6wind.com> (sfid-20170413_152734_492817_F5A2405F)
On Thu, 2017-04-13 at 15:27 +0200, Nicolas Dichtel wrote:
>
> > Yes, some - very few - families still insist on using attribute 0,
> > perhaps parsing by hand or so. Like you say though, the entire
> > infrastructure makes that hard and undesirable, so I don't really
> > see
> > why we need to invest the extra code/work into making it work
> > *here*,
> > especially since it's such a corner case as I described in my other
> > email.
>
> Here is an example:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co
> mmit/?id=31e20bad8d58
>
> I also see one in openvswitch (I will send a similar patch), but
> there are probably some others.
Yeah. I'm not really sure what the point of such a patch is though -
the API is set now, and can't really be changed.
Anyway, the ones you point out are only used for *output* by the
kernel, so wouldn't be affected by any "missing attribute" reporting
anyway.
johannes
next prev parent reply other threads:[~2017-04-13 13:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 17:48 [PATCH 0/5] extended netlink ACK reporting Johannes Berg
2017-04-08 17:48 ` [PATCH 1/5] netlink: extended " Johannes Berg
2017-04-08 18:26 ` David Ahern
2017-04-08 18:34 ` Jiri Pirko
2017-04-08 18:37 ` Johannes Berg
2017-04-08 18:40 ` Jiri Pirko
2017-04-08 20:13 ` Johannes Berg
2017-04-09 17:43 ` David Ahern
2017-04-10 6:18 ` Johannes Berg
2017-04-13 13:27 ` Nicolas Dichtel
2017-04-13 13:29 ` Johannes Berg [this message]
2017-04-13 14:05 ` Nicolas Dichtel
2017-04-13 19:24 ` Johannes Berg
2017-04-16 14:40 ` second wave of netlink " Jamal Hadi Salim
2017-04-16 14:45 ` David Ahern
2017-04-16 14:48 ` Jamal Hadi Salim
2017-04-16 14:50 ` David Ahern
2017-04-16 16:55 ` David Ahern
[not found] ` <CAPWQB7FWOcEen3SGyQtW7t2WpDNLE08JEdHeZHmM738J=Rur0g@mail.gmail.com>
2017-04-18 9:41 ` [PATCH 1/5] netlink: " Johannes Berg
2017-04-18 23:46 ` Joe Stringer
2017-04-08 18:36 ` David Ahern
2017-04-08 18:37 ` Johannes Berg
2017-04-08 20:14 ` David Ahern
2017-04-08 17:48 ` [PATCH 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-08 17:48 ` [PATCH 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 17:48 ` [PATCH 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-08 18:50 ` David Ahern
2017-04-08 20:15 ` Johannes Berg
2017-04-08 17:49 ` [PATCH 5/5] netlink: pass extended ACK struct where available Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492090170.29526.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dsa@cumulusnetworks.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).