linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Benc <jbenc@redhat.com>,
	jiri@resnulli.us, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 4/5] netlink: pass extended ACK struct to parsing functions
Date: Sat, 8 Apr 2017 14:50:09 -0400	[thread overview]
Message-ID: <3077bf17-553d-f9e3-8873-c59fbb26e2aa@cumulusnetworks.com> (raw)
In-Reply-To: <20170408174900.12820-5-johannes@sipsolutions.net>

On 4/8/17 1:48 PM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Pass the new extended ACK reporting struct to all of the
> generic netlink parsing functions. For now, pass NULL in
> almost all callers (except for some in the core.)
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

fails to compile as well:

In file included from /home/dsa/kernel-4.git/net/sched/cls_rsvp.c:27:0:
/home/dsa/kernel-4.git/net/sched/cls_rsvp.h: In function ‘rsvp_change’:
/home/dsa/kernel-4.git/net/sched/cls_rsvp.h:487:8: error: too few
arguments to function ‘nla_parse_nested’
  err = nla_parse_nested(tb, TCA_RSVP_MAX, opt, rsvp_policy);
        ^
In file included from /home/dsa/kernel-4.git/include/net/rtnetlink.h:5:0,
                 from /home/dsa/kernel-4.git/include/net/sch_generic.h:12,
                 from /home/dsa/kernel-4.git/include/linux/filter.h:20,
                 from /home/dsa/kernel-4.git/include/net/sock.h:64,
                 from /home/dsa/kernel-4.git/include/net/inet_sock.h:27,
                 from /home/dsa/kernel-4.git/include/net/ip.h:30,
                 from /home/dsa/kernel-4.git/net/sched/cls_rsvp.c:18:
/home/dsa/kernel-4.git/include/net/netlink.h:754:19: note: declared here
 static inline int nla_parse_nested(struct nlattr *tb[], int maxtype,

  reply	other threads:[~2017-04-08 18:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08 17:48 [PATCH 0/5] extended netlink ACK reporting Johannes Berg
2017-04-08 17:48 ` [PATCH 1/5] netlink: extended " Johannes Berg
2017-04-08 18:26   ` David Ahern
2017-04-08 18:34   ` Jiri Pirko
2017-04-08 18:37     ` Johannes Berg
2017-04-08 18:40       ` Jiri Pirko
2017-04-08 20:13         ` Johannes Berg
2017-04-09 17:43         ` David Ahern
2017-04-10  6:18           ` Johannes Berg
2017-04-13 13:27             ` Nicolas Dichtel
2017-04-13 13:29               ` Johannes Berg
2017-04-13 14:05                 ` Nicolas Dichtel
2017-04-13 19:24                   ` Johannes Berg
2017-04-16 14:40                     ` second wave of netlink " Jamal Hadi Salim
2017-04-16 14:45                       ` David Ahern
2017-04-16 14:48                         ` Jamal Hadi Salim
2017-04-16 14:50                           ` David Ahern
2017-04-16 16:55                       ` David Ahern
     [not found]                     ` <CAPWQB7FWOcEen3SGyQtW7t2WpDNLE08JEdHeZHmM738J=Rur0g@mail.gmail.com>
2017-04-18  9:41                       ` [PATCH 1/5] netlink: " Johannes Berg
2017-04-18 23:46                         ` Joe Stringer
2017-04-08 18:36   ` David Ahern
2017-04-08 18:37     ` Johannes Berg
2017-04-08 20:14   ` David Ahern
2017-04-08 17:48 ` [PATCH 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-08 17:48 ` [PATCH 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 17:48 ` [PATCH 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-08 18:50   ` David Ahern [this message]
2017-04-08 20:15     ` Johannes Berg
2017-04-08 17:49 ` [PATCH 5/5] netlink: pass extended ACK struct where available Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3077bf17-553d-f9e3-8873-c59fbb26e2aa@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=jbenc@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).